From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=AE58=DO=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 75B56C4363C
	for <netdev@archiver.kernel.org>; Wed,  7 Oct 2020 11:18:58 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 28A3E20B1F
	for <netdev@archiver.kernel.org>; Wed,  7 Oct 2020 11:18:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1602069538;
	bh=zw0n7Q6vqIwxN2eQAkiygtAkgWUFMpxyiyTNt9ZDXhU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=kP28v0CkhDdhQMcu3siyrMGW6mzMBwNjx85Vm4RKXbucaFyCFZcjfhU037YYaAqvv
	 TJ42MyPK/e1ksd7Apx9gSumAdtopqj0c70wfV3MdBr1g8QuiVVRsA75TZlycaraW/C
	 YywsCgorTCtOSEMg4xavgeNCIK0gWBTGdjGA9c0Y=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727416AbgJGLS5 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 7 Oct 2020 07:18:57 -0400
Received: from mail.kernel.org ([198.145.29.99]:52512 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726730AbgJGLS5 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 7 Oct 2020 07:18:57 -0400
Received: from localhost (unknown [213.57.247.131])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id DFEBD2075A;
        Wed,  7 Oct 2020 11:18:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1602069536;
        bh=zw0n7Q6vqIwxN2eQAkiygtAkgWUFMpxyiyTNt9ZDXhU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=L5Io4qDFVAH3R/f+acwtHjrIS9+xZImma5sPW4IaEeIMDZBA4F0ejWx9Hy7Lxf4Jx
         fts1rpjEYYeHjEluo1jtkgIYI2GuFvAIn8NwVcVfAnvSkt78tBsXHgwygwMi1mUZ9S
         mXVXEnCvUDojayFUMdyxcPnrcAYP6FhDnL5MK3E8=
Date:   Wed, 7 Oct 2020 14:18:52 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] ethtool: correct policy for ETHTOOL_MSG_CHANNELS_SET
Message-ID: <20201007111852.GE3678159@unreal>
References: <20201007125348.a0b250308599.Ie9b429e276d064f28ce12db01fffa430e5c770e0@changeid>
 <20201007125348.a74389e18168.Ieab7a871e27b9698826e75dc9e825e4ddbc852b1@changeid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201007125348.a74389e18168.Ieab7a871e27b9698826e75dc9e825e4ddbc852b1@changeid>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, Oct 07, 2020 at 12:53:51PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> This accidentally got wired up to the *get* policy instead
> of the *set* policy, causing operations to be rejected. Fix
> it by wiring up the correct policy instead.
>
> Fixes: 5028588b62cb ("ethtool: wire up set policies to ops")
> Reported-by: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  net/ethtool/netlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Thanks,
Tested-by: Leon Romanovsky <leonro@nvidia.com>