From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8891C47095 for ; Wed, 7 Oct 2020 15:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8884620782 for ; Wed, 7 Oct 2020 15:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="HmuQOSO5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728782AbgJGPqY (ORCPT ); Wed, 7 Oct 2020 11:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728769AbgJGPqV (ORCPT ); Wed, 7 Oct 2020 11:46:21 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D37C0613D2 for ; Wed, 7 Oct 2020 08:46:21 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id n18so2768921wrs.5 for ; Wed, 07 Oct 2020 08:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YzPiSX7AQ1L9YnXrnLU91iAOqoFafCUH8YuU1FCjhMc=; b=HmuQOSO5fQzzPoNooQ98zkg3PTY6swd4ETESnICsiJr6LKNVV0WEsV8kBq9p+YJSZl 14LLqkPF7gSHmgpFN3Rv7Wid+GDiKlRXAQqkDDRLkcL8D3b3nX+R243/oeNaHvpaGCsw HCXmyxlDIFx4qPL3IxeI9ZLisjCcZC/HKgGSHoTT2hEdLXjjSbbsoEjPEgcMGtSwDnmS p+NrMcNj/QklFSMbPoX2hLQOSlbEjBKBTsiEx4nNGYXKCJC7HWv1493vmlE9QYCls3Fp VjGyamtXkRoQKfKsziofoTvhBEy92/v2Bbt8RbwTmLGvzaiINVBHBn92Z1BBiCF+V7Ha TrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YzPiSX7AQ1L9YnXrnLU91iAOqoFafCUH8YuU1FCjhMc=; b=ClmZtBXT0eSNPMsIseHqLNtY++1+BTcV//KAecu8CeLXPmYM4JE5sVCVvQ0rDSbjK8 h5JKZO4aSgbYsENnPz5DgTxKrRuhp+Znv25Mg9MD6cvsQlcOLuA8FupiD0raCHXRdtun 5KZJQWzX9F+qJQWbVQQIMCYUABfSLbLDl/DBLk/H9rxYSEu7VyNid+uLHNys2kRvxDME QSpdmqIL7Okk90n7HOMHrEP7TNtn0XHFIJ5984RvUhaFgz8aHhArp7xBGc4THdBJknJc z1nzNFbpK96Oi5JEwBz847K10JSQxmHENWzV0DJpXY1CDcUKrOC+97UCo3skHwMewfhi DPrg== X-Gm-Message-State: AOAM533ysVSAuk56aNwz1zqTP6TlQPUy6GJTXmzndEv5uYTbokOJGf2a XlwOVGZwrO1/3hvoMAi5lQugPQ== X-Google-Smtp-Source: ABdhPJwAUva8Y6sfFj4UDNguAWXZjtX41JdpwwGKDeXgg/qMbYOvETz04L0/DLuh/b5zsSxQC9ixew== X-Received: by 2002:adf:91a4:: with SMTP id 33mr4521604wri.170.1602085579687; Wed, 07 Oct 2020 08:46:19 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id p21sm3253767wmc.28.2020.10.07.08.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 08:46:19 -0700 (PDT) Date: Wed, 7 Oct 2020 17:46:18 +0200 From: Jiri Pirko To: Moshe Shemesh , f@nanopsycho Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 04/16] devlink: Add reload stats Message-ID: <20201007154618.GB3064@nanopsycho> References: <1602050457-21700-1-git-send-email-moshe@mellanox.com> <1602050457-21700-5-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602050457-21700-5-git-send-email-moshe@mellanox.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Oct 07, 2020 at 08:00:45AM CEST, moshe@mellanox.com wrote: >Add reload stats to hold the history per reload action type and limit. > >For example, the number of times fw_activate has been performed on this >device since the driver module was added or if the firmware activation >was performed with or without reset. > >Add devlink notification on stats update. > >Expose devlink reload stats to the user through devlink dev get command. > >Examples: >$ devlink dev show >pci/0000:82:00.0: > stats: > reload: > driver_reinit 2 fw_activate 1 fw_activate_no_reset 0 >pci/0000:82:00.1: > stats: > reload: > driver_reinit 1 fw_activate 0 fw_activate_no_reset 0 > >$ devlink dev show -jp >{ > "dev": { > "pci/0000:82:00.0": { > "stats": { > "reload": { > "driver_reinit": 2, > "fw_activate": 1, > "fw_activate_no_reset": 0 > } > } > }, > "pci/0000:82:00.1": { > "stats": { > "reload": { > "driver_reinit": 1, > "fw_activate": 0, > "fw_activate_no_reset": 0 > } > } > } > } >} > >Signed-off-by: Moshe Shemesh Reviewed-by: Jiri Pirko