From: Aleksandr Nogikh <a.nogikh@gmail.com>
To: davem@davemloft.net, kuba@kernel.org, johannes@sipsolutions.net,
akpm@linux-foundation.org
Cc: edumazet@google.com, andreyknvl@google.com, dvyukov@google.com,
elver@google.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
nogikh@google.com
Subject: [PATCH v2 1/3] kernel: make kcov_common_handle consider the current context
Date: Fri, 9 Oct 2020 17:02:00 +0000 [thread overview]
Message-ID: <20201009170202.103512-2-a.nogikh@gmail.com> (raw)
In-Reply-To: <20201009170202.103512-1-a.nogikh@gmail.com>
From: Aleksandr Nogikh <nogikh@google.com>
kcov_common_handle is a method that is used to obtain a "default" KCOV
remote handle of the current process. The handle can later be passed
to kcov_remote_start in order to collect coverage for the processing
that is initiated by one process, but done in another. For details see
Documentation/dev-tools/kcov.rst and comments in kernel/kcov.c.
Presently, if kcov_common_handle is called in a hard IRQ context, it
will return a handle for the interrupted process. This may lead to
unreliable and incorrect coverage collection.
Adjust the behavior of kcov_common_handle in the following way. If it
is called in a task context, return the common handle for the
currently running task. Otherwise, return 0. It will make the returned
value more reliable and also will make it possible to use
kcov_remote_handle in routines that can be called from any context.
Signed-off-by: Aleksandr Nogikh <nogikh@google.com>
---
v2:
* Added this patch to the series.
---
kernel/kcov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 6b8368be89c8..80bfe71bbe13 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -1023,6 +1023,8 @@ EXPORT_SYMBOL(kcov_remote_stop);
/* See the comment before kcov_remote_start() for usage details. */
u64 kcov_common_handle(void)
{
+ if (!in_task())
+ return 0;
return current->kcov_handle;
}
EXPORT_SYMBOL(kcov_common_handle);
--
2.28.0.1011.ga647a8990f-goog
next prev parent reply other threads:[~2020-10-09 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 17:01 [PATCH v2 0/3] [PATCH v2 0/3] [PATCH v2 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling Aleksandr Nogikh
2020-10-09 17:02 ` Aleksandr Nogikh [this message]
2020-10-14 16:03 ` [PATCH v2 1/3] kernel: make kcov_common_handle consider the current context Andrey Konovalov
2020-10-09 17:02 ` [PATCH v2 2/3] net: store KCOV remote handle in sk_buff Aleksandr Nogikh
2020-10-09 17:02 ` [PATCH v2 3/3] mac80211: add KCOV remote annotations to incoming frame processing Aleksandr Nogikh
2020-10-09 17:13 ` [PATCH v2 0/3] [PATCH v2 0/3] [PATCH v2 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling Johannes Berg
2020-10-11 10:37 ` Andrey Konovalov
2020-10-11 11:09 ` Johannes Berg
2020-10-11 18:50 ` Johannes Berg
2020-10-11 18:53 ` Andrey Konovalov
2020-10-12 11:18 ` Aleksandr Nogikh
2020-10-12 11:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009170202.103512-2-a.nogikh@gmail.com \
--to=a.nogikh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nogikh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).