From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D38C43457 for ; Mon, 12 Oct 2020 10:43:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B4F7208FE for ; Mon, 12 Oct 2020 10:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387640AbgJLKnA (ORCPT ); Mon, 12 Oct 2020 06:43:00 -0400 Received: from hosting.gsystem.sk ([212.5.213.30]:37818 "EHLO hosting.gsystem.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387463AbgJLKnA (ORCPT ); Mon, 12 Oct 2020 06:43:00 -0400 Received: from [192.168.1.3] (ns.gsystem.sk [62.176.172.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 8B83D7A0192; Mon, 12 Oct 2020 12:42:58 +0200 (CEST) From: Ondrej Zary To: Jakub Kicinski Subject: Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot Date: Mon, 12 Oct 2020 12:42:55 +0200 User-Agent: KMail/1.9.10 Cc: Oliver Neukum , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201010140048.12067-1-linux@zary.sk> <20201011155539.315bf5aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201011155539.315bf5aa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <202010121242.55826.linux@zary.sk> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Monday 12 October 2020, Jakub Kicinski wrote: > On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote: > > When the router is rebooted without a power cycle, the USB device > > remains connected but its configuration is reset. This results in > > a non-working ethernet connection with messages like this in syslog: > > usb 2-2: RX packet too long: 65535 B > > > > Re-enable ethernet mode when receiving a packet with invalid size of > > 0xffff. > > Patch looks good, but could you explain what's a reboot without a power > cycle in this case? The modem gets reset but USB subsystem doesn't know > it and doesn't go though a unbind() + bind() cycle? The router can be rebooted through the web interface. The reboot does not disconnect the USB device - it remains connected as if nothing happened. Only wrong data starts to come in. -- Ondrej Zary