From: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <roopa@nvidia.com>, <nikolay@nvidia.com>,
<jiri@mellanox.com>, <idosch@mellanox.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<bridge@lists.linux-foundation.org>,
<UNGLinuxDriver@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.
Date: Mon, 19 Oct 2020 08:51:04 +0000 [thread overview]
Message-ID: <20201019085104.2hkz2za2o2juliab@soft-test08> (raw)
In-Reply-To: <20201015103431.25d66c8b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Thank you for the review. Comments below.
The 10/15/2020 10:34, Jakub Kicinski wrote:
>
> On Thu, 15 Oct 2020 11:54:15 +0000 Henrik Bjoernlund wrote:
> > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = {
> > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 },
>
> NLA_POLICY_MAX(NLA_U32, 7)
I will change as requested.
>
> Also why did you keep the validation in the code in patch 4?
In patch 4 there is no CFM NETLINK so I desided to keep the validation in the
code until NETLINK was added that is now doing the check.
I this a problem?
--
/Henrik
next prev parent reply other threads:[~2020-10-19 8:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 11:54 [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 01/10] net: bridge: extend the process of special frames Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface Henrik Bjoernlund
2020-10-15 17:34 ` Jakub Kicinski
2020-10-19 8:51 ` Henrik Bjoernlund [this message]
2020-10-19 16:21 ` Jakub Kicinski
2020-10-21 9:17 ` Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 08/10] bridge: cfm: Netlink GET " Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 09/10] bridge: cfm: Netlink GET status Interface Henrik Bjoernlund
2020-10-15 11:54 ` [PATCH net-next v6 10/10] bridge: cfm: Netlink Notifications Henrik Bjoernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019085104.2hkz2za2o2juliab@soft-test08 \
--to=henrik.bjoernlund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).