From: Andrew Lunn <andrew@lunn.ch>
To: Robert Hancock <robert.hancock@calian.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111
Date: Mon, 19 Oct 2020 23:00:23 +0200 [thread overview]
Message-ID: <20201019210023.GU139700@lunn.ch> (raw)
In-Reply-To: <20201019204913.467287-1-robert.hancock@calian.com>
> +static int m88e1111_finisar_config_init(struct phy_device *phydev)
> +{
> + int err;
> + int extsr = phy_read(phydev, MII_M1111_PHY_EXT_SR);
> +
> + if (extsr < 0)
> + return extsr;
> +
> + /* If using 1000BaseX and 1000BaseX auto-negotiation is disabled, enable it */
> + if (phydev->interface == PHY_INTERFACE_MODE_1000BASEX &&
> + (extsr & MII_M1111_HWCFG_MODE_MASK) ==
> + MII_M1111_HWCFG_MODE_COPPER_1000BX_NOAN) {
> + err = phy_modify(phydev, MII_M1111_PHY_EXT_SR,
> + MII_M1111_HWCFG_MODE_MASK |
> + MII_M1111_HWCFG_SERIAL_AN_BYPASS,
> + MII_M1111_HWCFG_MODE_COPPER_1000BX_AN |
> + MII_M1111_HWCFG_SERIAL_AN_BYPASS);
> + if (err < 0)
> + return err;
> + }
> +
> + return m88e1111_config_init(phydev);
> +}
Hi Robert
Is this really specific to the Finisar? It seems like any application
of the m88e1111 in 1000BaseX would benefit from this?
Andrew
next prev parent reply other threads:[~2020-10-19 21:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:49 [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111 Robert Hancock
2020-10-19 21:00 ` Andrew Lunn [this message]
2020-10-19 21:43 ` Robert Hancock
2020-10-19 21:59 ` Andrew Lunn
2020-10-19 22:11 ` Robert Hancock
2020-10-19 21:06 ` Andrew Lunn
2020-10-19 21:09 ` Russell King - ARM Linux admin
2020-10-19 21:08 ` Russell King - ARM Linux admin
2020-10-19 21:32 ` Robert Hancock
2020-10-19 21:45 ` Andrew Lunn
2020-10-19 21:59 ` Robert Hancock
2020-10-19 22:12 ` Andrew Lunn
2020-10-19 22:21 ` Russell King - ARM Linux admin
2020-10-19 22:26 ` Robert Hancock
2020-10-19 22:03 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019210023.GU139700@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robert.hancock@calian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).