From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Robert Hancock <robert.hancock@calian.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111
Date: Mon, 19 Oct 2020 22:08:53 +0100 [thread overview]
Message-ID: <20201019210852.GW1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201019204913.467287-1-robert.hancock@calian.com>
On Mon, Oct 19, 2020 at 02:49:13PM -0600, Robert Hancock wrote:
> The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 81E1111 PHY
You mean 88E1111 here.
> with a modified PHY ID, and by default does not have 1000BaseX
> auto-negotiation enabled, which is not generally desirable with Linux
> networking drivers. Add handling to enable 1000BaseX auto-negotiation.
> Also, it requires some special handling to ensure that 1000BaseT auto-
> negotiation is enabled properly when desired.
>
> Based on existing handling in the AMD xgbe driver and the information in
> the Finisar FAQ:
> https://www.finisar.com/sites/default/files/resources/an-2036_1000base-t_sfp_faqreve1.pdf
There's lots of modules that have the 88E1111 PHY on, and we switch
it to SGMII mode if it's not already in SGMII mode if we have access
to it. Why is your setup different?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-19 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:49 [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111 Robert Hancock
2020-10-19 21:00 ` Andrew Lunn
2020-10-19 21:43 ` Robert Hancock
2020-10-19 21:59 ` Andrew Lunn
2020-10-19 22:11 ` Robert Hancock
2020-10-19 21:06 ` Andrew Lunn
2020-10-19 21:09 ` Russell King - ARM Linux admin
2020-10-19 21:08 ` Russell King - ARM Linux admin [this message]
2020-10-19 21:32 ` Robert Hancock
2020-10-19 21:45 ` Andrew Lunn
2020-10-19 21:59 ` Robert Hancock
2020-10-19 22:12 ` Andrew Lunn
2020-10-19 22:21 ` Russell King - ARM Linux admin
2020-10-19 22:26 ` Robert Hancock
2020-10-19 22:03 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019210852.GW1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robert.hancock@calian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).