From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Yunjian Wang <wangyunjian@huawei.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: Have netpoll bring-up DSA management interface
Date: Tue, 20 Oct 2020 00:19:16 +0300 [thread overview]
Message-ID: <20201019211916.j77jptfpryrhau4z@skbuf> (raw)
In-Reply-To: <58b07285-bb70-3115-eb03-5e43a4abeae6@gmail.com>
On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
> > Completely crazy and outlandish idea, I know, but what's wrong with
> > doing this in DSA?
>
> I really do not have a problem with that approach however other stacked
> devices like 802.1Q do not do that. It certainly scales a lot better to
> do this within DSA rather than sprinkling DSA specific knowledge
> throughout the network stack. Maybe for "configuration less" stacked
> devices such as DSA, 802.1Q (bridge ports?), bond etc. it would be
> acceptable to ensure that the lower device is always brought up?
For upper interfaces with more than one lower (bridge, bond) I'm not so
sure. For uppers with a single lower (DSA, 8021q), it's pretty much a
no-brainer to me. Question is, where to code this? I think it's ok to
leave it in DSA, then 8021q could copy it as well if there was a need.
next prev parent reply other threads:[~2020-10-19 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 17:17 [PATCH net] net: Have netpoll bring-up DSA management interface Florian Fainelli
2020-10-19 20:02 ` Vladimir Oltean
2020-10-19 21:03 ` Florian Fainelli
2020-10-19 21:19 ` Vladimir Oltean [this message]
2020-10-21 1:12 ` Jakub Kicinski
2020-11-16 23:06 ` Florian Fainelli
2020-11-16 23:20 ` Florian Fainelli
2020-11-16 23:37 ` Vladimir Oltean
2020-11-16 23:47 ` Jakub Kicinski
2020-11-16 23:54 ` Vladimir Oltean
2020-11-17 0:04 ` Jakub Kicinski
2020-11-17 0:12 ` Vladimir Oltean
2020-11-17 0:16 ` Florian Fainelli
2020-11-17 0:53 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019211916.j77jptfpryrhau4z@skbuf \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox