From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94CEC433DF for ; Mon, 19 Oct 2020 21:59:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A51022404 for ; Mon, 19 Oct 2020 21:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387742AbgJSV7t (ORCPT ); Mon, 19 Oct 2020 17:59:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35492 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387732AbgJSV7t (ORCPT ); Mon, 19 Oct 2020 17:59:49 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kUdBw-002Yt7-JV; Mon, 19 Oct 2020 23:59:44 +0200 Date: Mon, 19 Oct 2020 23:59:44 +0200 From: Andrew Lunn To: Robert Hancock Cc: "linux@armlinux.org.uk" , "hkallweit1@gmail.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" Subject: Re: [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111 Message-ID: <20201019215944.GZ139700@lunn.ch> References: <20201019204913.467287-1-robert.hancock@calian.com> <20201019210023.GU139700@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I suppose that part would be pretty harmless, as you would likely want > that behavior whenever that if condition was triggered. So > m88e1111_finisar_config_init could likely be merged into > m88e1111_config_init. I think so as well. > Mainly what stopped me from making all of these changes generic to all > 88E1111 is that I'm a bit less confident in the different config_aneg > behavior, it might be more specific to this SFP copper module case? Well, for 1000BaseX, i don't think we currently have an SFP devices using it, since phylink does not support it. So it is a question are there any none-SFP m88e1111 out there you might break? Andrew