From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374BAC433DF for ; Mon, 19 Oct 2020 22:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69CD4223FD for ; Mon, 19 Oct 2020 22:22:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="qYoKLhF2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728903AbgJSWWB (ORCPT ); Mon, 19 Oct 2020 18:22:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728386AbgJSWWB (ORCPT ); Mon, 19 Oct 2020 18:22:01 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 330BAC0613CE for ; Mon, 19 Oct 2020 15:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5PO86Zr88F0Fnk+CGMKrRv8Xg89gFWnynN6gPPhdl7E=; b=qYoKLhF203CIcy42d0mKHPKR4 4ZK4gEZoW3Yw1h//9CAj7eoFVLHlCUaeo8M7zXvWfHZa8fBNW3MliC/DXaxM/+k6TWIRmeyThBiA7 qnAPNqJbuRuCyT5cRAaB95YyBOJUKHqahIkuZ9c9JbPqV8l+PKltHwhNrsdVxKBE3v5k5AwhcZ/t5 AR+LhzyqXjhmW7CfK0nYusCOE5WpULKXXjT9HVWE8qhkkJr5icIAr9x9yP3eJhBv7SkLJHm5gd9R8 QwUfd4qmFn/VI2JteeHhBQZrzYuhGgzSbh8k6QFsT9L4mzRN5gZPslgh5AqPB4QehoYGFy7d6FnBw Q7prGAaeQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48406) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUdXQ-0006RE-Gw; Mon, 19 Oct 2020 23:21:56 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kUdXN-0004cH-LX; Mon, 19 Oct 2020 23:21:53 +0100 Date: Mon, 19 Oct 2020 23:21:53 +0100 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Robert Hancock , "hkallweit1@gmail.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" Subject: Re: [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111 Message-ID: <20201019222153.GZ1551@shell.armlinux.org.uk> References: <20201019204913.467287-1-robert.hancock@calian.com> <20201019210852.GW1551@shell.armlinux.org.uk> <30161ca241d03c201e801af7089dada5b6481c24.camel@calian.com> <20201019214536.GX139700@lunn.ch> <1f3243e15a8600dd9876b97410b450029674c50c.camel@calian.com> <20201019221232.GB139700@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019221232.GB139700@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 20, 2020 at 12:12:32AM +0200, Andrew Lunn wrote: > > The auto-negotiation is a bit of a weird thing in this case, as there > > are two negotiations occurring, the 1000BaseX between the PCS/PMA PHY > > and the module PHY, and the 1000BaseT between the module PHY and the > > copper link partner. I believe the 88E1111 has some smarts to delay the > > copper negotiation until it gets the advertisement over 1000BaseX, uses > > those to figure out its advertisement, and then uses the copper link > > partner's response to determine the 1000BaseX response. > > But as far as i know you can only report duplex and pause over > 1000BaseX, not speed, since it is always 1G. That is correct. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!