From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY
Date: Tue, 20 Oct 2020 20:56:01 +0200 [thread overview]
Message-ID: <20201020185601.GJ139700@lunn.ch> (raw)
In-Reply-To: <20201020171221.730-3-dmurphy@ti.com>
> + ti,master-slave-mode:
> + $ref: /schemas/types.yaml#definitions/uint32
> + default: 0
> + description: |
> + Force the PHY to be configured to a specific mode.
> + Force Auto Negotiation - 0
> + Force Master mode at 1v p2p - 1
> + Force Master mode at 2.4v p2p - 2
> + Force Slave mode at 1v p2p - 3
> + Force Slave mode at 2.4v p2p - 4
> + enum: [ 0, 1, 2, 3, 4 ]
Is this a board hardware property? The fact value 0 means auto-neg
suggests not.
We already have ethtool configuration of master/slave for T1 PHYs:
ommit bdbdac7649fac05f88c9f7ab18121a17fb591687
Author: Oleksij Rempel <linux@rempel-privat.de>
Date: Tue May 5 08:35:05 2020 +0200
ethtool: provide UAPI for PHY master/slave configuration.
This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of
auto-negotiation support, we needed to be able to configure the
MASTER-SLAVE role of the port manually or from an application in user
space.
Please can you look at using that UAPI.
I assume that 1v p2p is the voltage of the signal put onto the twisted
pair? I know the Marvell 1000BaseT PHYs allow this to be configured as
well, but just downwards to save power. Maybe a PHY tunable would be
better?
Humm. Are 1v and 2.4v advertised so it can be auto negotiated? Maybe a
PHY tunable is not correct? Is this voltage selection actually more
like pause and EEE?
Andrew
next prev parent reply other threads:[~2020-10-20 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 17:12 [PATCH net-next v2 0/3] DP83TD510 Single Pair 10Mbps Ethernet PHY Dan Murphy
2020-10-20 17:12 ` [PATCH net-next v2 1/3] ethtool: Add 10base-T1L link mode entries Dan Murphy
2020-10-20 17:12 ` [PATCH net-next v2 2/3] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY Dan Murphy
2020-10-20 18:56 ` Andrew Lunn [this message]
2020-10-20 19:07 ` Andrew Lunn
2020-10-20 19:14 ` Dan Murphy
2020-10-20 17:12 ` [PATCH net-next v2 3/3] net: phy: dp83td510: Add support for the " Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020185601.GJ139700@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).