From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: eric.snowberg@oracle.com, john.haxby@oracle.com,
todd.vierling@oracle.com
Cc: Matthew Garrett <mjg59@google.com>,
netdev@vger.kernel.org, Chun-Yi Lee <jlee@suse.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH RFC UEK5 2/7] bpf: Restrict bpf when kernel lockdown is in confidentiality mode
Date: Tue, 20 Oct 2020 17:06:34 -0400 [thread overview]
Message-ID: <20201020210634.GA21080@char.us.oracle.com> (raw)
In-Reply-To: <20201020210004.18977-3-konrad.wilk@oracle.com>
On Tue, Oct 20, 2020 at 04:59:59PM -0400, Konrad Rzeszutek Wilk wrote:
> bpf_read() and bpf_read_str() could potentially be abused to (eg) allow
> private keys in kernel memory to be leaked. Disable them if the kernel
> has been locked down in confidentiality mode.
>
> Suggested-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Signed-off-by: Matthew Garrett <mjg59@google.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> cc: netdev@vger.kernel.org
> cc: Chun-Yi Lee <jlee@suse.com>
> cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: James Morris <jmorris@namei.org>
>
> [Backport notes:
> The upstream version is using enums, and all that fancy code.
> We are just retroffiting UEK5 a bit and just checking to
> see if integrity mode has been enabled and if so then
> allow it. If the default lockdown mode (confidentiality) is on
> then we don't allow it.]
<sigh>
And that is what I get for _not_ doing --suppress-cc=all
My apologies for spamming you all!
<goes to hide in the corner of shame>
prev parent reply other threads:[~2020-10-20 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201020210004.18977-1-konrad.wilk@oracle.com>
2020-10-20 20:59 ` [PATCH RFC UEK5 2/7] bpf: Restrict bpf when kernel lockdown is in confidentiality mode Konrad Rzeszutek Wilk
2020-10-20 21:06 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020210634.GA21080@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eric.snowberg@oracle.com \
--cc=jlee@suse.com \
--cc=jmorris@namei.org \
--cc=john.haxby@oracle.com \
--cc=mjg59@google.com \
--cc=netdev@vger.kernel.org \
--cc=todd.vierling@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).