* [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel
@ 2020-10-20 11:43 Alexander Ovechkin
2020-10-21 2:28 ` David Ahern
2020-10-21 9:30 ` Guillaume Nault
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Ovechkin @ 2020-10-20 11:43 UTC (permalink / raw)
To: netdev
mpls_iptunnel is used only for mpls encapsuation, and if encaplusated
packet is larger than MTU we need mpls_gso for segmentation.
Signed-off-by: Alexander Ovechkin <ovov@yandex-team.ru>
Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
---
net/mpls/mpls_iptunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
index 2def85718d94..ef59e25dc482 100644
--- a/net/mpls/mpls_iptunnel.c
+++ b/net/mpls/mpls_iptunnel.c
@@ -300,5 +300,6 @@ static void __exit mpls_iptunnel_exit(void)
module_exit(mpls_iptunnel_exit);
MODULE_ALIAS_RTNL_LWT(MPLS);
+MODULE_SOFTDEP("post: mpls_gso");
MODULE_DESCRIPTION("MultiProtocol Label Switching IP Tunnels");
MODULE_LICENSE("GPL v2");
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel
2020-10-20 11:43 [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel Alexander Ovechkin
@ 2020-10-21 2:28 ` David Ahern
2020-10-21 4:18 ` Jakub Kicinski
2020-10-21 9:30 ` Guillaume Nault
1 sibling, 1 reply; 4+ messages in thread
From: David Ahern @ 2020-10-21 2:28 UTC (permalink / raw)
To: Alexander Ovechkin, netdev
On 10/20/20 5:43 AM, Alexander Ovechkin wrote:
> mpls_iptunnel is used only for mpls encapsuation, and if encaplusated
> packet is larger than MTU we need mpls_gso for segmentation.
>
> Signed-off-by: Alexander Ovechkin <ovov@yandex-team.ru>
> Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
> ---
> net/mpls/mpls_iptunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
> index 2def85718d94..ef59e25dc482 100644
> --- a/net/mpls/mpls_iptunnel.c
> +++ b/net/mpls/mpls_iptunnel.c
> @@ -300,5 +300,6 @@ static void __exit mpls_iptunnel_exit(void)
> module_exit(mpls_iptunnel_exit);
>
> MODULE_ALIAS_RTNL_LWT(MPLS);
> +MODULE_SOFTDEP("post: mpls_gso");
> MODULE_DESCRIPTION("MultiProtocol Label Switching IP Tunnels");
> MODULE_LICENSE("GPL v2");
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel
2020-10-21 2:28 ` David Ahern
@ 2020-10-21 4:18 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-10-21 4:18 UTC (permalink / raw)
To: David Ahern; +Cc: Alexander Ovechkin, netdev
On Tue, 20 Oct 2020 20:28:25 -0600 David Ahern wrote:
> On 10/20/20 5:43 AM, Alexander Ovechkin wrote:
> > mpls_iptunnel is used only for mpls encapsuation, and if encaplusated
> > packet is larger than MTU we need mpls_gso for segmentation.
> >
> > Signed-off-by: Alexander Ovechkin <ovov@yandex-team.ru>
> > Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
>
> Reviewed-by: David Ahern <dsahern@gmail.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel
2020-10-20 11:43 [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel Alexander Ovechkin
2020-10-21 2:28 ` David Ahern
@ 2020-10-21 9:30 ` Guillaume Nault
1 sibling, 0 replies; 4+ messages in thread
From: Guillaume Nault @ 2020-10-21 9:30 UTC (permalink / raw)
To: Alexander Ovechkin; +Cc: netdev, David Ahern
On Tue, Oct 20, 2020 at 02:43:33PM +0300, Alexander Ovechkin wrote:
> mpls_iptunnel is used only for mpls encapsuation, and if encaplusated
> packet is larger than MTU we need mpls_gso for segmentation.
>
> Signed-off-by: Alexander Ovechkin <ovov@yandex-team.ru>
> Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
> ---
> net/mpls/mpls_iptunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
> index 2def85718d94..ef59e25dc482 100644
> --- a/net/mpls/mpls_iptunnel.c
> +++ b/net/mpls/mpls_iptunnel.c
> @@ -300,5 +300,6 @@ static void __exit mpls_iptunnel_exit(void)
> module_exit(mpls_iptunnel_exit);
>
> MODULE_ALIAS_RTNL_LWT(MPLS);
> +MODULE_SOFTDEP("post: mpls_gso");
> MODULE_DESCRIPTION("MultiProtocol Label Switching IP Tunnels");
> MODULE_LICENSE("GPL v2");
Then CONFIG_MPLS_IPTUNNEL should probably select CONFIG_NET_MPLS_GSO.
Currently, one can build mpls_iptunnel.ko without mpls_gso.ko.
Also, MPLS encapsulation can also be done with act_mpls.ko. So this
module should probably have this softdep too (and the Kconfig
dependency).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-21 9:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-20 11:43 [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel Alexander Ovechkin
2020-10-21 2:28 ` David Ahern
2020-10-21 4:18 ` Jakub Kicinski
2020-10-21 9:30 ` Guillaume Nault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).