From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux@armlinux.org.uk, David Miller <davem@davemloft.net>,
kuba@kernel.org
Subject: Re: [PATCH 2/2] net: phy: adin: implement cable-test support
Date: Wed, 21 Oct 2020 16:28:04 +0200 [thread overview]
Message-ID: <20201021142804.GP139700@lunn.ch> (raw)
In-Reply-To: <CA+U=DsrZM4gRpmez6KqT8XTEBYwA-gwHjHQWa3Pn+G1nsYD3CA@mail.gmail.com>
> Actually, I'd also be interested [for this PHY], to report a
> "significance impedance" detection, which is similar to the
> short-detection that is already done.
You can add that as just another element of the enum.
> At first, this report would sound like it could be interesting; but
> feel free to disagree with me.
>
> And there's also some "busy" indicator; as-in "unknown activity during
> diagnostics"; to-be-honest, I don't know what this is yet.
The link partner did not go quiet. You can only do cable tests if the
partner is not sending frames or pulses. You will find most PHYs have
some sort of error status for this. For the Marvell driver, this is
MII_VCT7_RESULTS_INVALID. In that case, the Marvell driver returns
ETHTOOL_A_CABLE_RESULT_CODE_UNSPEC.
Andrew
next prev parent reply other threads:[~2020-10-21 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 13:51 [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg Alexandru Ardelean
2020-10-21 13:51 ` [PATCH 2/2] net: phy: adin: implement cable-test support Alexandru Ardelean
2020-10-21 14:08 ` Andrew Lunn
2020-10-21 14:16 ` Alexandru Ardelean
2020-10-21 14:28 ` Andrew Lunn [this message]
2020-10-21 14:46 ` Alexandru Ardelean
2020-10-21 13:58 ` [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg Andrew Lunn
2020-10-21 14:05 ` Alexandru Ardelean
2020-10-21 14:13 ` Andrew Lunn
2020-10-21 14:23 ` Alexandru Ardelean
2020-10-21 16:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021142804.GP139700@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).