From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C33BC55179 for ; Wed, 21 Oct 2020 14:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46E072224E for ; Wed, 21 Oct 2020 14:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2443503AbgJUO2H (ORCPT ); Wed, 21 Oct 2020 10:28:07 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38286 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437408AbgJUO2G (ORCPT ); Wed, 21 Oct 2020 10:28:06 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kVF5w-002pSb-NS; Wed, 21 Oct 2020 16:28:04 +0200 Date: Wed, 21 Oct 2020 16:28:04 +0200 From: Andrew Lunn To: Alexandru Ardelean Cc: Alexandru Ardelean , netdev@vger.kernel.org, LKML , Heiner Kallweit , linux@armlinux.org.uk, David Miller , kuba@kernel.org Subject: Re: [PATCH 2/2] net: phy: adin: implement cable-test support Message-ID: <20201021142804.GP139700@lunn.ch> References: <20201021135140.51300-1-alexandru.ardelean@analog.com> <20201021135140.51300-2-alexandru.ardelean@analog.com> <20201021140852.GN139700@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Actually, I'd also be interested [for this PHY], to report a > "significance impedance" detection, which is similar to the > short-detection that is already done. You can add that as just another element of the enum. > At first, this report would sound like it could be interesting; but > feel free to disagree with me. > > And there's also some "busy" indicator; as-in "unknown activity during > diagnostics"; to-be-honest, I don't know what this is yet. The link partner did not go quiet. You can only do cable tests if the partner is not sending frames or pulses. You will find most PHYs have some sort of error status for this. For the Marvell driver, this is MII_VCT7_RESULTS_INVALID. In that case, the Marvell driver returns ETHTOOL_A_CABLE_RESULT_CODE_UNSPEC. Andrew