From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C36C56201 for ; Wed, 21 Oct 2020 16:34:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CBA522453 for ; Wed, 21 Oct 2020 16:34:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502960AbgJUQe2 (ORCPT ); Wed, 21 Oct 2020 12:34:28 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38450 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438161AbgJUQe2 (ORCPT ); Wed, 21 Oct 2020 12:34:28 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kVH4C-002qId-8a; Wed, 21 Oct 2020 18:34:24 +0200 Date: Wed, 21 Oct 2020 18:34:24 +0200 From: Andrew Lunn To: Alexandru Ardelean Cc: Alexandru Ardelean , netdev@vger.kernel.org, LKML , Heiner Kallweit , linux@armlinux.org.uk, David Miller , kuba@kernel.org Subject: Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg Message-ID: <20201021163424.GQ139700@lunn.ch> References: <20201021135140.51300-1-alexandru.ardelean@analog.com> <20201021135802.GM139700@lunn.ch> <20201021141342.GO139700@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > i'll think about the frame-generator; Here were the two main problems i can remember with my first version: How do you discover what is can actually do? You probably need to collect up all the open PHY datasheets and get an idea what the different vendors provide, what is common, what could be shared extensions etc, and think about how you can describe the capabilities. Probably a netlink call will be needed to return what the hardware is capable of doing. At the time, it was necessary to hold RTNL while performing packet generation. That is bad, because it means most of the control plane stops for all devices. We will need to copy some of the ideas from the cable test to avoid this, adding a state to the state machine, etc. Andrew