* [PATCH] net-veth: Fix memleak in veth_newlink
@ 2020-10-22 5:42 Dinghao Liu
2020-10-22 16:12 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2020-10-22 5:42 UTC (permalink / raw)
To: dinghao.liu, kjlu; +Cc: David S. Miller, Jakub Kicinski, netdev, linux-kernel
When rtnl_configure_link() fails, peer needs to be
freed just like when register_netdevice() fails.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/net/veth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 8c737668008a..6c68094399cc 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1405,8 +1405,6 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
/* nothing to do */
err_configure_peer:
unregister_netdevice(peer);
- return err;
-
err_register_peer:
free_netdev(peer);
return err;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net-veth: Fix memleak in veth_newlink
2020-10-22 5:42 [PATCH] net-veth: Fix memleak in veth_newlink Dinghao Liu
@ 2020-10-22 16:12 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-22 16:12 UTC (permalink / raw)
To: Dinghao Liu; +Cc: kjlu, David S. Miller, netdev, linux-kernel
On Thu, 22 Oct 2020 13:42:33 +0800 Dinghao Liu wrote:
> When rtnl_configure_link() fails, peer needs to be
> freed just like when register_netdevice() fails.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Can you see this leak or are you just sending this based on your
reading of the code?
netdev should be freed by the core:
static void veth_setup(struct net_device *dev)
{
ether_setup(dev);
[...]
dev->needs_free_netdev = true;
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index 8c737668008a..6c68094399cc 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -1405,8 +1405,6 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
> /* nothing to do */
> err_configure_peer:
> unregister_netdevice(peer);
> - return err;
> -
> err_register_peer:
> free_netdev(peer);
> return err;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-22 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-22 5:42 [PATCH] net-veth: Fix memleak in veth_newlink Dinghao Liu
2020-10-22 16:12 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).