From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFB9C388F9 for ; Fri, 23 Oct 2020 13:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31EAB2465B for ; Fri, 23 Oct 2020 13:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="j5UPJ/it" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750169AbgJWN4t (ORCPT ); Fri, 23 Oct 2020 09:56:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750146AbgJWN4s (ORCPT ); Fri, 23 Oct 2020 09:56:48 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 905E6C0613CE; Fri, 23 Oct 2020 06:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yP+Q48wjyA1OtcAwAs6WtGA6NCAOZIUoYj9ZiEEVx+0=; b=j5UPJ/itw1xdW6ep+I1m7UHQm ob4rOr6elyUGAyYU0Me2YV5fMc0ECSL/cVI1BO9W9/nrL5B/9Kvt6/YFGU01JNN4HRxLWmibHYet1 QtA/C+5//NcXiu/cl3Z1K3TEQEJ3bry6aM3RISxKLhFknrrTuRb1NjqJmTPf+9vNhW8dSOjnZ2JNB T9W3IWcpwpbyNqWvjknpu3R485AKnl1THo/i75y5QZmj/sBvFz6boBr7dHNYcBN+iYygiUNc1uMSJ 3k80MrIkURWZXjosAfVlhY1yJ+5q3i+x7rZGpctuiugcTE06q69gOPR6SqCYe7OgLR00PjkzQTI9Q SVsepb4kw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50000) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVxYg-0003Y1-CZ; Fri, 23 Oct 2020 14:56:42 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVxYc-0008V4-7h; Fri, 23 Oct 2020 14:56:38 +0100 Date: Fri, 23 Oct 2020 14:56:38 +0100 From: Russell King - ARM Linux admin To: Parshuram Raju Thombare Cc: "andrew@lunn.ch" , "nicolas.ferre@microchip.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Milind Parab Subject: Re: [PATCH v3] net: macb: add support for high speed interface Message-ID: <20201023135638.GE1551@shell.armlinux.org.uk> References: <1603302245-30654-1-git-send-email-pthombar@cadence.com> <20201021185056.GN1551@shell.armlinux.org.uk> <20201023112549.GB1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 23, 2020 at 01:34:09PM +0000, Parshuram Raju Thombare wrote: > >Whenever the interface changes, we go through the full reconfiguration > >procedure that I've already outlined. This involves calling the > >mac_prepare() method which calls into mvpp2_mac_prepare() and its > >child mvpp2__mac_prepare(). > > Ok, I misunderstood it as interface mode change between successive mac_prepare(). > If major reconfiguration is certain to happen after every interface mode change, > I will make another small modification in mac_prepare method to set appropriate > pcs_ops for selected interface mode. > pcs_ops for low speed, however, will just be existing non 10GBASE-R functions renamed. > This will allow us to get rid of old API's for non 10GBASE-R PCS. I hope you are ok with > these changes done in the same patch. Yes, that sounds good. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!