From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81788C5517A for ; Fri, 23 Oct 2020 20:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D6B820882 for ; Fri, 23 Oct 2020 20:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755998AbgJWUSS (ORCPT ); Fri, 23 Oct 2020 16:18:18 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42302 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755987AbgJWUSS (ORCPT ); Fri, 23 Oct 2020 16:18:18 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kW3Vn-003Ake-7G; Fri, 23 Oct 2020 22:18:07 +0200 Date: Fri, 23 Oct 2020 22:18:07 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Oliver Hartkopp , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , mkl@pengutronix.de, Marek Vasut , linux-can@vger.kernel.org Subject: Re: [RFC PATCH v1 1/6] net: phy: add CAN PHY Virtual Bus Message-ID: <20201023201807.GC752111@lunn.ch> References: <20201023105626.6534-1-o.rempel@pengutronix.de> <20201023105626.6534-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201023105626.6534-2-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 23, 2020 at 12:56:21PM +0200, Oleksij Rempel wrote: > Most of CAN PHYs (transceivers) are not attached to any data bus, so we > are not able to communicate with them. For this case, we introduce a CAN > specific virtual bus to make use of existing PHY framework. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/phy/Kconfig | 8 ++ > drivers/net/phy/Makefile | 1 + > drivers/net/phy/can_phy_bus.c | 196 ++++++++++++++++++++++++++++++++++ Hi Oleksij mdio drivers have moved to drivers/net/mdio. > include/linux/can/phy.h | 21 ++++ > 4 files changed, 226 insertions(+) > create mode 100644 drivers/net/phy/can_phy_bus.c > create mode 100644 include/linux/can/phy.h > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index 698bea312adc..39e3f57ea60a 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -153,6 +153,14 @@ config BCM_CYGNUS_PHY > config BCM_NET_PHYLIB > tristate > > +config CAN_PHY_BUS > + tristate "Virtual CAN PHY Bus" > + depends on PHYLIB > + help > + Most CAN PHYs (transceivers) are not attached to any data bus, so we > + are not able to communicate with them. For this case, a CAN specific > + virtual bus to make use of existing PHY framework. Is there anything CAN specific here? Maybe we should just call it a virtual PHY bus? Andrew