From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497F5C55178 for ; Fri, 23 Oct 2020 20:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E564E20882 for ; Fri, 23 Oct 2020 20:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756033AbgJWUYd (ORCPT ); Fri, 23 Oct 2020 16:24:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42324 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S376076AbgJWUYd (ORCPT ); Fri, 23 Oct 2020 16:24:33 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kW3br-003Ami-1t; Fri, 23 Oct 2020 22:24:23 +0200 Date: Fri, 23 Oct 2020 22:24:23 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Oliver Hartkopp , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , mkl@pengutronix.de, Marek Vasut , linux-can@vger.kernel.org Subject: Re: [RFC PATCH v1 3/6] net: phy: add CAN interface mode Message-ID: <20201023202423.GD752111@lunn.ch> References: <20201023105626.6534-1-o.rempel@pengutronix.de> <20201023105626.6534-4-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201023105626.6534-4-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 23, 2020 at 12:56:23PM +0200, Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel > --- > drivers/net/phy/phy.c | 2 ++ > include/linux/phy.h | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 35525a671400..4fb355df3e61 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -324,6 +324,8 @@ void phy_ethtool_ksettings_get(struct phy_device *phydev, > cmd->base.master_slave_state = phydev->master_slave_state; > if (phydev->interface == PHY_INTERFACE_MODE_MOCA) > cmd->base.port = PORT_BNC; > + else if (phydev->interface == PHY_INTERFACE_MODE_CAN) > + cmd->base.port = PORT_OTHER; > else > cmd->base.port = PORT_MII; There is nothing stopping you from adding CAN specific PORT_ types. Andrew