From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20531C4363A for ; Mon, 26 Oct 2020 15:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED52A241A4 for ; Mon, 26 Oct 2020 15:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783953AbgJZPeG convert rfc822-to-8bit (ORCPT ); Mon, 26 Oct 2020 11:34:06 -0400 Received: from mga11.intel.com ([192.55.52.93]:1757 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783948AbgJZPeF (ORCPT ); Mon, 26 Oct 2020 11:34:05 -0400 IronPort-SDR: BeD7JecPN3cROovTRJAXgTsLaAmhfEZpyJJTA9Pmehi8Pbvnqpg/SgT3H3QgYakXtxPx3u3ELs jgwz75fWYjaw== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="164442767" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="164442767" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 08:34:03 -0700 IronPort-SDR: bHLp3u9rWJruRvlfdwSmKZnRsIzhkd/dyEO0u8F0t2jYAtmQIXcLIkmHHMiFzpJKAmYtlO/Mmp CzaD0IEmwM2Q== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="317893389" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.236.36]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 08:33:58 -0700 Date: Mon, 26 Oct 2020 08:33:56 -0700 From: Jesse Brandeburg To: Christian Langrock Cc: , , Subject: Re: Subject: [PATCH net] drivers: net: ixgbe: Fix *_ipsec_offload_ok():, Use ip_hdr family Message-ID: <20201026083356.00001999@intel.com> In-Reply-To: <1581f61a-f405-008a-8f31-e9e696667d5a@secunet.com> References: <1581f61a-f405-008a-8f31-e9e696667d5a@secunet.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Christian Langrock wrote: Please fix your subject, remove the word 'Subject: ' > Xfrm_dev_offload_ok() is called with the unencrypted SKB. So in case of > interfamily ipsec traffic (IPv4-in-IPv6 and IPv6 in IPv4) the check > assumes the wrong family of the skb (IP family of the state). > With this patch the ip header of the SKB is used to determine the > family. > missing "Fixes: " line? It's useful here because I think this looks like a good candidate for stable bug fix. > Signed-off-by: Christian Langrock > --- >  drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +- >  drivers/net/ethernet/intel/ixgbevf/ipsec.c     | 2 +- >  2 files changed, 2 insertions(+), 2 deletions(-) The patch looks ok otherwise, thanks!