From: Jason Gunthorpe <jgg@nvidia.com>
To: Chao Leng <lengchao@huawei.com>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Doug Ledford <dledford@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Keith Busch <kbusch@kernel.org>, <linux-nvme@lists.infradead.org>,
<linux-rdma@vger.kernel.org>, Max Gurtovoy <mgurtovoy@nvidia.com>,
<netdev@vger.kernel.org>, <rds-devel@oss.oracle.com>,
Sagi Grimberg <sagi@grimberg.me>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH] RDMA: Add rdma_connect_locked()
Date: Tue, 27 Oct 2020 09:00:41 -0300 [thread overview]
Message-ID: <20201027120041.GI1523783@nvidia.com> (raw)
In-Reply-To: <e13ec119-3cc6-87ab-bc76-d2d3de7631e4@huawei.com>
On Tue, Oct 27, 2020 at 10:01:00AM +0800, Chao Leng wrote:
> > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> > index aad829a2b50d0f..f488dc5f4c2c61 100644
> > +++ b/drivers/nvme/host/rdma.c
> > @@ -1730,11 +1730,10 @@ static void nvme_rdma_process_nvme_rsp(struct nvme_rdma_queue *queue,
> > req->result = cqe->result;
> > if (wc->wc_flags & IB_WC_WITH_INVALIDATE) {
> > - if (unlikely(!req->mr ||
> > - wc->ex.invalidate_rkey != req->mr->rkey)) {
> > + if (unlikely(wc->ex.invalidate_rkey != req->mr->rkey)) {
> > dev_err(queue->ctrl->ctrl.device,
> > "Bogus remote invalidation for rkey %#x\n",
> > - req->mr ? req->mr->rkey : 0);
> > + req->mr->rkey);
> Maybe the code version is incorrect, cause falsely code rollback.
Oh wow, thanks for noticing that, I made a git fumble when doing this
:(
Jason
next prev parent reply other threads:[~2020-10-27 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:25 [PATCH] RDMA: Add rdma_connect_locked() Jason Gunthorpe
2020-10-26 16:01 ` santosh.shilimkar
2020-10-27 2:01 ` Chao Leng
2020-10-27 12:00 ` Jason Gunthorpe [this message]
2020-10-27 7:33 ` Jinpu Wang
2020-10-27 8:04 ` Christoph Hellwig
2020-10-27 12:05 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027120041.GI1523783@nvidia.com \
--to=jgg@nvidia.com \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=hch@lst.de \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=leonro@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sagi@grimberg.me \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).