From: Guillaume Nault <gnault@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Alexander Ovechkin <ovov@yandex-team.ru>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 net] net/sched: act_mpls: Add softdep on mpls_gso.ko
Date: Tue, 27 Oct 2020 22:39:51 +0100 [thread overview]
Message-ID: <20201027213951.GA13892@pc-2.home> (raw)
In-Reply-To: <CAM_iQpVBpdJyzfexy8Vnxqa7wH0MhcxkatzQhdOtrskg=dva+A@mail.gmail.com>
On Tue, Oct 27, 2020 at 10:28:29AM -0700, Cong Wang wrote:
> On Mon, Oct 26, 2020 at 4:23 AM Guillaume Nault <gnault@redhat.com> wrote:
> >
> > TCA_MPLS_ACT_PUSH and TCA_MPLS_ACT_MAC_PUSH might be used on gso
> > packets. Such packets will thus require mpls_gso.ko for segmentation.
>
> Any reason not to call request_module() at run time?
So that mpls_gso would be loaded only when initialising the
TCA_MPLS_ACT_PUSH or TCA_MPLS_ACT_MAC_PUSH modes?
That could be done, but the dependency on mpls_gso wouldn't be visible
anymore with modinfo. I don't really mind, I just felt that such
information could be important for the end user.
next prev parent reply other threads:[~2020-10-27 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 10:29 [PATCH v2 net] net/sched: act_mpls: Add softdep on mpls_gso.ko Guillaume Nault
2020-10-27 17:28 ` Cong Wang
2020-10-27 21:39 ` Guillaume Nault [this message]
2020-10-27 21:51 ` David Ahern
2020-10-28 19:35 ` Cong Wang
2020-10-28 21:45 ` Guillaume Nault
2020-10-28 0:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027213951.GA13892@pc-2.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ovov@yandex-team.ru \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).