From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] net: dsa: link aggregation support
Date: Wed, 28 Oct 2020 02:03:49 +0100 [thread overview]
Message-ID: <20201028010349.GA930647@lunn.ch> (raw)
In-Reply-To: <87361zuqjs.fsf@waldekranz.com>
On Wed, Oct 28, 2020 at 01:45:11AM +0100, Tobias Waldekranz wrote:
> On Tue, Oct 27, 2020 at 23:36, Andrew Lunn <andrew@lunn.ch> wrote:
> > If you are dynamically allocating dsa_lag structures, at run time, you
> > need to think about this. But the number of LAGs is limited by the
> > number of ports. So i would consider just allocating the worst case
> > number at probe, and KISS for runtime.
>
> Oh OK, yeah that just makes stuff easier so that's absolutely fine. I
> got the sense that the overall movement within DSA was in the opposite
> direction. E.g. didn't the dst use to have an array of ds pointers?
> Whereas now you iterate through dst->ports to find them?
Yes, but they are all allocated at probe time. It saved a bit of heap
for adding some code.
Andrew
next prev parent reply other threads:[~2020-10-29 0:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 10:51 [RFC PATCH 0/4] net: dsa: link aggregation support Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 1/4] net: dsa: mv88e6xxx: use ethertyped dsa for 6390/6390X Tobias Waldekranz
2020-10-27 14:52 ` Marek Behun
2020-10-27 14:54 ` Marek Behun
2020-10-27 14:58 ` Marek Behun
2020-10-27 10:51 ` [RFC PATCH 2/4] net: dsa: link aggregation support Tobias Waldekranz
2020-10-28 0:58 ` Vladimir Oltean
2020-10-28 14:03 ` Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 3/4] net: dsa: mv88e6xxx: " Tobias Waldekranz
2020-10-27 10:51 ` [RFC PATCH 4/4] net: dsa: tag_edsa: support reception of packets from lag devices Tobias Waldekranz
2020-10-28 12:05 ` Vladimir Oltean
2020-10-28 15:28 ` Tobias Waldekranz
2020-10-28 18:18 ` Vladimir Oltean
2020-10-28 22:31 ` Tobias Waldekranz
2020-10-28 23:08 ` Vladimir Oltean
2020-10-29 7:47 ` Tobias Waldekranz
2020-10-30 9:21 ` Vladimir Oltean
2020-11-01 11:31 ` Ido Schimmel
2020-10-27 12:27 ` [RFC PATCH 0/4] net: dsa: link aggregation support Vladimir Oltean
2020-10-27 14:29 ` Andrew Lunn
2020-10-27 14:59 ` Tobias Waldekranz
2020-10-27 14:00 ` Andrew Lunn
2020-10-27 15:09 ` Tobias Waldekranz
2020-10-27 15:05 ` Marek Behun
2020-10-27 15:23 ` Andrew Lunn
2020-10-27 18:25 ` Tobias Waldekranz
2020-10-27 18:33 ` Marek Behun
2020-10-27 19:04 ` Vladimir Oltean
2020-10-27 19:21 ` Tobias Waldekranz
2020-10-27 19:00 ` Vladimir Oltean
2020-10-27 19:37 ` Tobias Waldekranz
2020-10-27 20:02 ` Vladimir Oltean
2020-10-27 20:53 ` Tobias Waldekranz
2020-10-27 22:32 ` Vladimir Oltean
2020-10-28 0:27 ` Tobias Waldekranz
2020-10-28 22:35 ` Marek Behun
2020-10-27 22:36 ` Andrew Lunn
2020-10-28 0:45 ` Tobias Waldekranz
2020-10-28 1:03 ` Andrew Lunn [this message]
2020-11-11 4:28 ` Florian Fainelli
2020-11-19 10:51 ` Vladimir Oltean
2020-11-19 11:52 ` Tobias Waldekranz
2020-11-19 18:12 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028010349.GA930647@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).