netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: ipv6: calipso: Fix kerneldoc warnings
@ 2020-10-28  1:33 Andrew Lunn
  2020-10-30 19:17 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2020-10-28  1:33 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: netdev, Alexey Kuznetsov, Hideaki YOSHIFUJI, Andrew Lunn

net/ipv6/calipso.c:1236: warning: Excess function parameter 'reg' description in 'calipso_req_delattr'
net/ipv6/calipso.c:1236: warning: Function parameter or member 'req' not described in 'calipso_req_delattr'
net/ipv6/calipso.c:435: warning: Excess function parameter 'audit_secid' description in 'calipso_doi_remove'
net/ipv6/calipso.c:435: warning: Function parameter or member 'audit_info' not described in 'calipso_doi_remove'

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 net/ipv6/calipso.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/calipso.c b/net/ipv6/calipso.c
index 78f766019b7e..51184a70ac7e 100644
--- a/net/ipv6/calipso.c
+++ b/net/ipv6/calipso.c
@@ -423,7 +423,7 @@ static void calipso_doi_free_rcu(struct rcu_head *entry)
 /**
  * calipso_doi_remove - Remove an existing DOI from the CALIPSO protocol engine
  * @doi: the DOI value
- * @audit_secid: the LSM secid to use in the audit message
+ * @audit_info: NetLabel audit information
  *
  * Description:
  * Removes a DOI definition from the CALIPSO engine.  The NetLabel routines will
@@ -1226,7 +1226,7 @@ static int calipso_req_setattr(struct request_sock *req,
 
 /**
  * calipso_req_delattr - Delete the CALIPSO option from a request socket
- * @reg: the request socket
+ * @req: the request socket
  *
  * Description:
  * Removes the CALIPSO option from a request socket, if present.
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: ipv6: calipso: Fix kerneldoc warnings
  2020-10-28  1:33 [PATCH net-next] net: ipv6: calipso: Fix kerneldoc warnings Andrew Lunn
@ 2020-10-30 19:17 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-30 19:17 UTC (permalink / raw)
  To: Andrew Lunn; +Cc: netdev, Alexey Kuznetsov, Hideaki YOSHIFUJI

On Wed, 28 Oct 2020 02:33:44 +0100 Andrew Lunn wrote:
> net/ipv6/calipso.c:1236: warning: Excess function parameter 'reg' description in 'calipso_req_delattr'
> net/ipv6/calipso.c:1236: warning: Function parameter or member 'req' not described in 'calipso_req_delattr'
> net/ipv6/calipso.c:435: warning: Excess function parameter 'audit_secid' description in 'calipso_doi_remove'
> net/ipv6/calipso.c:435: warning: Function parameter or member 'audit_info' not described in 'calipso_doi_remove'
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Thanks Andrew, I applied all your W=1 fixes that hit patchwork.

I had to add review tags manually (probably due to the vger hiccup PW
didn't take them) and correct some spellings.

If there is anything I missed please resend :)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-30 19:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28  1:33 [PATCH net-next] net: ipv6: calipso: Fix kerneldoc warnings Andrew Lunn
2020-10-30 19:17 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).