From: Andrew Lunn <andrew@lunn.ch>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: tipc: Add __printf() markup to fix -Wsuggest-attribute=format
Date: Thu, 29 Oct 2020 13:40:17 +0100 [thread overview]
Message-ID: <20201029124017.GI933237@lunn.ch> (raw)
In-Reply-To: <202010291009.4MeXI3UF-lkp@intel.com>
On Thu, Oct 29, 2020 at 10:49:34AM +0800, kernel test robot wrote:
> Hi Andrew,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Andrew-Lunn/net-dccp-Add-__printf-markup-to-fix-Wsuggest-attribute-format/20201029-081346
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cd29296fdfca919590e4004a7e4905544f4c4a32
> config: arc-allyesconfig (attached as .config)
> compiler: arceb-elf-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/0be08855cea6e7b987406c1beee6ca1b508f5066
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Andrew-Lunn/net-dccp-Add-__printf-markup-to-fix-Wsuggest-attribute-format/20201029-081346
> git checkout 0be08855cea6e7b987406c1beee6ca1b508f5066
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> net/tipc/netlink_compat.c: In function 'tipc_nl_compat_link_stat_dump':
> >> net/tipc/netlink_compat.c:591:39: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'void *' [-Wformat=]
> 591 | tipc_tlv_sprintf(msg->rep, "\nLink <%s>\n",
> | ~^
> | |
> | char *
> | %p
> 592 | nla_data(link[TIPC_NLA_LINK_NAME]));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | void *
Yep, which is the point of adding this markup, and why there is a
follow up patch fixing this.
Please don't let this 0-day report stop the commit being merged.
Andrew
prev parent reply other threads:[~2020-10-29 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 0:38 [PATCH net-next 0/2] Markup some printk like functions Andrew Lunn
2020-10-28 0:38 ` [PATCH net-next 1/2] net: dccp: Add __printf() markup to fix -Wsuggest-attribute=format Andrew Lunn
2020-10-28 0:38 ` [PATCH net-next 2/2] net: tipc: " Andrew Lunn
[not found] ` <202010291009.4MeXI3UF-lkp@intel.com>
2020-10-29 12:40 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029124017.GI933237@lunn.ch \
--to=andrew@lunn.ch \
--cc=kbuild-all@lists.01.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).