From: Andrew Lunn <andrew@lunn.ch>
To: Greg Ungerer <gerg@linux-m68k.org>
Cc: netdev@vger.kernel.org, fugang.duan@nxp.com, cphealy@gmail.com,
dkarr@vyex.com, clemens.gruber@pqgruber.com
Subject: Re: [PATCH v2] net: fec: fix MDIO probing for some FEC hardware blocks
Date: Fri, 30 Oct 2020 01:02:47 +0100 [thread overview]
Message-ID: <20201030000247.GA1013203@lunn.ch> (raw)
In-Reply-To: <20201028052232.1315167-1-gerg@linux-m68k.org>
On Wed, Oct 28, 2020 at 03:22:32PM +1000, Greg Ungerer wrote:
> Some (apparently older) versions of the FEC hardware block do not like
> the MMFR register being cleared to avoid generation of MII events at
> initialization time. The action of clearing this register results in no
> future MII events being generated at all on the problem block. This means
> the probing of the MDIO bus will find no PHYs.
>
> Create a quirk that can be checked at the FECs MII init time so that
> the right thing is done. The quirk is set as appropriate for the FEC
> hardware blocks that are known to need this.
>
> Fixes: f166f890c8f0 ("net: ethernet: fec: Replace interrupt driven MDIO with polled IO")
> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
Tested-by: Andrew Lunn <andrew@lunn.ch>
I tested this on Vybrid, which is not the best of platforms, since i
never had any of these problems on this platform.
Jakub, this is for net.
Andrew
next prev parent reply other threads:[~2020-10-30 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 5:22 [PATCH v2] net: fec: fix MDIO probing for some FEC hardware blocks Greg Ungerer
2020-10-28 5:28 ` [EXT] " Andy Duan
2020-10-30 0:02 ` Andrew Lunn [this message]
2020-10-30 15:26 ` Jakub Kicinski
2020-10-30 10:53 ` Clemens Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030000247.GA1013203@lunn.ch \
--to=andrew@lunn.ch \
--cc=clemens.gruber@pqgruber.com \
--cc=cphealy@gmail.com \
--cc=dkarr@vyex.com \
--cc=fugang.duan@nxp.com \
--cc=gerg@linux-m68k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).