From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED04C00A89 for ; Fri, 30 Oct 2020 16:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9A9D20727 for ; Fri, 30 Oct 2020 16:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="WDi/eacd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgJ3QdG (ORCPT ); Fri, 30 Oct 2020 12:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgJ3QdG (ORCPT ); Fri, 30 Oct 2020 12:33:06 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6919DC0613CF for ; Fri, 30 Oct 2020 09:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ryVIkuid+LF6WtFs6BrRr2Th95p4uo4ZVGTQNSn9rs0=; b=WDi/eacdvO7n7BViQiCBlCLo9 gWdWBx3n5bBujePKRJU89FxQgX9ykTelRspL4a0rqnd+4Qw3atuLmKruhfUORAKxSRrk1M5FkgNF0 FGGs6wnlHG39j0rMSI466SJpNp0HJWFa8iyDZu3nMQ9mMua8gn0CPKkM16wfV2mAHsFNXxencQDLF bjnlG99Xg+EV6DYB9pjoXM51aEwRnwOEaftiS0IaXIwuMfz0NrMNEpbXneOfXs0JVaCs/R4lJ7rzL 7AbcII8mvYfVkOYbo11hJ6WQzBSgzSbUIWt3UkBVcxvSC4j8zi5+e+Dy4Q4povmwXIULLK3cExVPl U86BG5DnQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52958) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYXKr-0006ML-6i; Fri, 30 Oct 2020 16:33:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kYXKq-0007JH-W6; Fri, 30 Oct 2020 16:33:05 +0000 Date: Fri, 30 Oct 2020 16:33:04 +0000 From: Russell King - ARM Linux admin To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, davem@davemloft.net, Andrew Lunn Subject: Re: [PATCH net-next v2 5/5] net: sfp: add support for multigig RollBall transceivers Message-ID: <20201030163304.GF1551@shell.armlinux.org.uk> References: <20201029222509.27201-1-kabel@kernel.org> <20201029222509.27201-6-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201029222509.27201-6-kabel@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Oct 29, 2020 at 11:25:09PM +0100, Marek Behún wrote: > This adds support for multigig copper SFP modules from RollBall/Hilink. > These modules have a specific way to access clause 45 registers of the > internal PHY. > > We also need to wait at least 25 seconds after deasserting TX disable > before accessing the PHY. The code waits for 30 seconds just to be sure. > > Signed-off-by: Marek Behún > Cc: Andrew Lunn > Cc: Russell King Reviewed-by: Russell King Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!