* [PATCH net] net: dsa: qca8k: Fix port MTU setting
@ 2020-10-30 18:33 Jonathan McDowell
2020-10-30 18:47 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan McDowell @ 2020-10-30 18:33 UTC (permalink / raw)
To: DENG Qingfang, Vladimir Oltean, Andrew Lunn, Vivien Didelot,
Florian Fainelli, David Miller, Jakub Kicinski, netdev,
linux-kernel
The qca8k only supports a switch-wide MTU setting, and the code to take
the max of all ports was only looking at the port currently being set.
Fix to examine all ports.
Reported-by: DENG Qingfang <dqfext@gmail.com>
Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks")
Cc: stable@vger.kernel.org
Signed-off-by: Jonathan McDowell <noodles@earth.li>
---
drivers/net/dsa/qca8k.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 53064e0e1618..5bdac669a339 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -1219,8 +1219,8 @@ qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
priv->port_mtu[port] = new_mtu;
for (i = 0; i < QCA8K_NUM_PORTS; i++)
- if (priv->port_mtu[port] > mtu)
- mtu = priv->port_mtu[port];
+ if (priv->port_mtu[i] > mtu)
+ mtu = priv->port_mtu[i];
/* Include L2 header / FCS length */
qca8k_write(priv, QCA8K_MAX_FRAME_SIZE, mtu + ETH_HLEN + ETH_FCS_LEN);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: qca8k: Fix port MTU setting
2020-10-30 18:33 [PATCH net] net: dsa: qca8k: Fix port MTU setting Jonathan McDowell
@ 2020-10-30 18:47 ` Andrew Lunn
2020-11-02 23:17 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2020-10-30 18:47 UTC (permalink / raw)
To: Jonathan McDowell
Cc: DENG Qingfang, Vladimir Oltean, Vivien Didelot, Florian Fainelli,
David Miller, Jakub Kicinski, netdev, linux-kernel
On Fri, Oct 30, 2020 at 06:33:15PM +0000, Jonathan McDowell wrote:
> The qca8k only supports a switch-wide MTU setting, and the code to take
> the max of all ports was only looking at the port currently being set.
> Fix to examine all ports.
>
> Reported-by: DENG Qingfang <dqfext@gmail.com>
> Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jonathan McDowell <noodles@earth.li>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: qca8k: Fix port MTU setting
2020-10-30 18:47 ` Andrew Lunn
@ 2020-11-02 23:17 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-02 23:17 UTC (permalink / raw)
To: Andrew Lunn
Cc: Jonathan McDowell, DENG Qingfang, Vladimir Oltean, Vivien Didelot,
Florian Fainelli, David Miller, netdev, linux-kernel
On Fri, 30 Oct 2020 19:47:33 +0100 Andrew Lunn wrote:
> On Fri, Oct 30, 2020 at 06:33:15PM +0000, Jonathan McDowell wrote:
> > The qca8k only supports a switch-wide MTU setting, and the code to take
> > the max of all ports was only looking at the port currently being set.
> > Fix to examine all ports.
> >
> > Reported-by: DENG Qingfang <dqfext@gmail.com>
> > Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Jonathan McDowell <noodles@earth.li>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-30 18:33 [PATCH net] net: dsa: qca8k: Fix port MTU setting Jonathan McDowell
2020-10-30 18:47 ` Andrew Lunn
2020-11-02 23:17 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).