public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
	vivien.didelot@gmail.com, Christian Eggers <ceggers@arri.de>,
	Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH v2 net-next 01/12] net: dsa: implement a central TX reallocation procedure
Date: Sun, 1 Nov 2020 03:14:34 +0200	[thread overview]
Message-ID: <20201101011434.e5crugmwy7drnvqt@skbuf> (raw)
In-Reply-To: <20201031180043.2f6bed15@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>

On Sat, Oct 31, 2020 at 06:00:43PM -0700, Jakub Kicinski wrote:
> On Fri, 30 Oct 2020 03:48:59 +0200 Vladimir Oltean wrote:
> > @@ -567,6 +591,17 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev)
> >  	 */
> >  	dsa_skb_tx_timestamp(p, skb);
> >  
> > +	if (dsa_realloc_skb(skb, dev)) {
> > +		kfree_skb(skb);
> 
> dev_kfree_skb_any()?

Just showing my ignorance, but where does the hardirq context come from?

  reply	other threads:[~2020-11-01  1:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  1:48 [PATCH v2 net-next 00/12] Generic TX reallocation for DSA Vladimir Oltean
2020-10-30  1:48 ` [PATCH v2 net-next 01/12] net: dsa: implement a central TX reallocation procedure Vladimir Oltean
2020-10-30  6:41   ` Kurt Kanzenbach
2020-11-01  1:00   ` Jakub Kicinski
2020-11-01  1:14     ` Vladimir Oltean [this message]
2020-11-01  1:37       ` Vladimir Oltean
2020-11-02 19:57         ` Jakub Kicinski
2020-10-30  1:49 ` [PATCH v2 net-next 02/12] net: dsa: tag_ksz: don't allocate additional memory for padding/tagging Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 03/12] net: dsa: trailer: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 04/12] net: dsa: tag_qca: let DSA core deal with TX reallocation Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 05/12] net: dsa: tag_ocelot: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 06/12] net: dsa: tag_mtk: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 07/12] net: dsa: tag_lan9303: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 08/12] net: dsa: tag_edsa: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 09/12] net: dsa: tag_brcm: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 10/12] net: dsa: tag_dsa: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 11/12] net: dsa: tag_gswip: " Vladimir Oltean
2020-10-30  1:49 ` [PATCH v2 net-next 12/12] net: dsa: tag_ar9331: " Vladimir Oltean
2020-10-30  9:21   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201101011434.e5crugmwy7drnvqt@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ceggers@arri.de \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox