netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: davem@davemloft.net
Cc: Lee Jones <lee.jones@linaro.org>,
	Harry Morris <h.morris@cascoda.com>,
	Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues
Date: Mon,  2 Nov 2020 11:45:02 +0000	[thread overview]
Message-ID: <20201102114512.1062724-21-lee.jones@linaro.org> (raw)
In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/net/ieee802154/ca8210.c:326: warning: Function parameter or member 'readq' not described in 'ca8210_test'
 drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'spi_transfer_complete' not described in 'ca8210_priv'
 drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'sync_exchange_complete' not described in 'ca8210_priv'
 drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'promiscuous' not described in 'ca8210_priv'
 drivers/net/ieee802154/ca8210.c:430: warning: Function parameter or member 'short_address' not described in 'macaddr'
 drivers/net/ieee802154/ca8210.c:723: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done'
 drivers/net/ieee802154/ca8210.c:723: warning: Excess function parameter 'arg' description in 'ca8210_rx_done'
 drivers/net/ieee802154/ca8210.c:1289: warning: Excess function parameter 'device_ref' description in 'tdme_checkpibattribute'
 drivers/net/ieee802154/ca8210.c:3054: warning: Function parameter or member 'spi_device' not described in 'ca8210_remove'
 drivers/net/ieee802154/ca8210.c:3054: warning: Excess function parameter 'priv' description in 'ca8210_remove'
 drivers/net/ieee802154/ca8210.c:3104: warning: Function parameter or member 'spi_device' not described in 'ca8210_probe'
 drivers/net/ieee802154/ca8210.c:3104: warning: Excess function parameter 'priv' description in 'ca8210_probe'

Cc: Harry Morris <h.morris@cascoda.com>
Cc: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wpan@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/net/ieee802154/ca8210.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 4eb64709d44cb..9b3ab7acad37e 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -316,6 +316,7 @@ struct cas_control {
  * struct ca8210_test - ca8210 test interface structure
  * @ca8210_dfs_spi_int: pointer to the entry in the debug fs for this device
  * @up_fifo:            fifo for upstream messages
+ * @readq:              read wait queue
  *
  * This structure stores all the data pertaining to the debug interface
  */
@@ -346,12 +347,12 @@ struct ca8210_test {
  * @ca8210_is_awake:        nonzero if ca8210 is initialised, ready for comms
  * @sync_down:              counts number of downstream synchronous commands
  * @sync_up:                counts number of upstream synchronous commands
- * @spi_transfer_complete   completion object for a single spi_transfer
- * @sync_exchange_complete  completion object for a complete synchronous API
- *                           exchange
- * @promiscuous             whether the ca8210 is in promiscuous mode or not
+ * @spi_transfer_complete:  completion object for a single spi_transfer
+ * @sync_exchange_complete: completion object for a complete synchronous API
+ *                          exchange
+ * @promiscuous:            whether the ca8210 is in promiscuous mode or not
  * @retries:                records how many times the current pending spi
- *                           transfer has been retried
+ *                          transfer has been retried
  */
 struct ca8210_priv {
 	struct spi_device *spi;
@@ -420,8 +421,8 @@ struct fulladdr {
 
 /**
  * union macaddr: generic MAC address container
- * @short_addr:   16-bit short address
- * @ieee_address: 64-bit extended address as LE byte array
+ * @short_address: 16-bit short address
+ * @ieee_address:  64-bit extended address as LE byte array
  *
  */
 union macaddr {
@@ -714,7 +715,7 @@ static void ca8210_mlme_reset_worker(struct work_struct *work)
 /**
  * ca8210_rx_done() - Calls various message dispatches responding to a received
  *                    command
- * @arg:  Pointer to the cas_control object for the relevant spi transfer
+ * @cas_ctrl: Pointer to the cas_control object for the relevant spi transfer
  *
  * Presents a received SAP command from the ca8210 to the Cascoda EVBME, test
  * interface and network driver.
@@ -1277,7 +1278,6 @@ static u8 tdme_channelinit(u8 channel, void *device_ref)
  * @pib_attribute:        Attribute Number
  * @pib_attribute_length: Attribute length
  * @pib_attribute_value:  Pointer to Attribute Value
- * @device_ref:           Nondescript pointer to target device
  *
  * Return: 802.15.4 status code of checks
  */
@@ -3046,7 +3046,7 @@ static void ca8210_test_interface_clear(struct ca8210_priv *priv)
 
 /**
  * ca8210_remove() - Shut down a ca8210 upon being disconnected
- * @priv:  Pointer to private data structure
+ * @spi_device:  Pointer to spi device data structure
  *
  * Return: 0 or linux error code
  */
@@ -3096,7 +3096,7 @@ static int ca8210_remove(struct spi_device *spi_device)
 
 /**
  * ca8210_probe() - Set up a connected ca8210 upon being detected by the system
- * @priv:  Pointer to private data structure
+ * @spi_device:  Pointer to spi device data structure
  *
  * Return: 0 or linux error code
  */
-- 
2.25.1


  parent reply	other threads:[~2020-11-02 11:48 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
2020-11-04  0:46   ` Jakub Kicinski
2020-11-04  7:28     ` Lee Jones
2020-11-04  7:30       ` Lee Jones
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 10:04   ` Lee Jones
2020-11-12 10:50     ` Greg KH
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
2020-11-02 11:44 ` [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
2020-11-02 11:45 ` Lee Jones [this message]
2020-11-03 16:18   ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Stefan Schmidt
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
2020-11-02 12:06   ` Hayes Wang
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
2020-11-03 16:19   ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
2020-11-02 12:06   ` Hayes Wang
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
2020-11-12 10:06   ` Lee Jones
2020-11-12 16:18     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102114512.1062724-21-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=h.morris@cascoda.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).