netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: davem@davemloft.net
Cc: Lee Jones <lee.jones@linaro.org>,
	Nicolas Pitre <nico@fluxnic.net>,
	Jakub Kicinski <kuba@kernel.org>, Erik Stahlman <erik@vt.edu>,
	Peter Cammaert <pc@denkart.be>, Daris A Nevil <dnevil@snmc.com>,
	Russell King <rmk@arm.linux.org.uk>,
	netdev@vger.kernel.org
Subject: [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused
Date: Mon,  2 Nov 2020 11:45:12 +0000	[thread overview]
Message-ID: <20201102114512.1062724-31-lee.jones@linaro.org> (raw)
In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org>

'pkt_len' is used to interact with a hardware register.  It might not
be safe to remove it entirely.  Mark it as __maybe_unused instead.

Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_tx’:
 drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set but not used [-Wunused-but-set-variable]

Cc: Nicolas Pitre <nico@fluxnic.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Erik Stahlman <erik@vt.edu>
Cc: Peter Cammaert <pc@denkart.be>
Cc: Daris A Nevil <dnevil@snmc.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/net/ethernet/smsc/smc91x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index b5d053292e717..a3f37b1f86491 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -703,7 +703,7 @@ static void smc_tx(struct net_device *dev)
 {
 	struct smc_local *lp = netdev_priv(dev);
 	void __iomem *ioaddr = lp->base;
-	unsigned int saved_packet, packet_no, tx_status, pkt_len;
+	unsigned int saved_packet, packet_no, tx_status, __maybe_unused pkt_len;
 
 	DBG(3, dev, "%s\n", __func__);
 
-- 
2.25.1


  parent reply	other threads:[~2020-11-02 11:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
2020-11-04  0:46   ` Jakub Kicinski
2020-11-04  7:28     ` Lee Jones
2020-11-04  7:30       ` Lee Jones
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 10:04   ` Lee Jones
2020-11-12 10:50     ` Greg KH
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
2020-11-02 11:44 ` [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
2020-11-03 16:18   ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
2020-11-02 12:06   ` Hayes Wang
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
2020-11-03 16:19   ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
2020-11-02 12:06   ` Hayes Wang
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
2020-11-02 11:45 ` Lee Jones [this message]
2020-11-12 10:06   ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
2020-11-12 16:18     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102114512.1062724-31-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=davem@davemloft.net \
    --cc=dnevil@snmc.com \
    --cc=erik@vt.edu \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=pc@denkart.be \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).