From: Lee Jones <lee.jones@linaro.org>
To: davem@davemloft.net
Cc: Lee Jones <lee.jones@linaro.org>,
Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
linux-wimax@intel.com, Jakub Kicinski <kuba@kernel.org>,
Yanir Lubetkin <yanirx.lubetkin@intel.com>,
netdev@vger.kernel.org
Subject: [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours
Date: Mon, 2 Nov 2020 11:44:48 +0000 [thread overview]
Message-ID: <20201102114512.1062724-7-lee.jones@linaro.org> (raw)
In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/net/wimax/i2400m/fw.c:584: warning: Function parameter or member 'i2400m' not described in 'i2400m_bm_cmd'
drivers/net/wimax/i2400m/fw.c:584: warning: Excess function parameter 'returns' description in 'i2400m_bm_cmd'
drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member 'chunk' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf' description in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf_len' description in 'i2400m_download_chunk'
drivers/net/wimax/i2400m/fw.c:1548: warning: Function parameter or member 'flags' not described in 'i2400m_dev_bootstrap'
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Yanir Lubetkin <yanirx.lubetkin@intel.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/staging/wimax/i2400m/fw.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
index 6c9a41bff2e0a..9970857063374 100644
--- a/drivers/staging/wimax/i2400m/fw.c
+++ b/drivers/staging/wimax/i2400m/fw.c
@@ -534,6 +534,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
/**
* i2400m_bm_cmd - Execute a boot mode command
*
+ * @i2400m: device descriptor
* @cmd: buffer containing the command data (pointing at the header).
* This data can be ANYWHERE (for USB, we will copy it to an
* specific buffer). Make sure everything is in proper little
@@ -566,7 +567,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
*
* @flags: see I2400M_BM_CMD_* above.
*
- * @returns: bytes received by the notification; if < 0, an errno code
+ * Returns: bytes received by the notification; if < 0, an errno code
* denoting an error or:
*
* -ERESTARTSYS The device has rebooted
@@ -634,8 +635,8 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m,
* i2400m_download_chunk - write a single chunk of data to the device's memory
*
* @i2400m: device descriptor
- * @buf: the buffer to write
- * @buf_len: length of the buffer to write
+ * @chunk: the buffer to write
+ * @chunk_len: length of the buffer to write
* @addr: address in the device memory space
* @direct: bootrom write mode
* @do_csum: should a checksum validation be performed
@@ -1533,6 +1534,13 @@ void i2400m_fw_put(struct i2400m_fw *i2400m_fw)
* i2400m_dev_bootstrap - Bring the device to a known state and upload firmware
*
* @i2400m: device descriptor
+ * @flags:
+ * I2400M_BRI_SOFT: a reboot barker has been seen
+ * already, so don't wait for it.
+ *
+ * I2400M_BRI_NO_REBOOT: Don't send a reboot command, but wait
+ * for a reboot barker notification. This is a one shot; if
+ * the state machine needs to send a reboot command it will.
*
* Returns: >= 0 if ok, < 0 errno code on error.
*
--
2.25.1
next prev parent reply other threads:[~2020-11-02 11:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201102114512.1062724-1-lee.jones@linaro.org>
2020-11-02 11:44 ` [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Lee Jones
2020-11-04 0:46 ` Jakub Kicinski
2020-11-04 7:28 ` Lee Jones
2020-11-04 7:30 ` Lee Jones
2020-11-02 11:44 ` [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used " Lee Jones
2020-11-02 11:44 ` [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Lee Jones
2020-11-12 10:04 ` Lee Jones
2020-11-12 10:50 ` Greg KH
2020-11-02 11:44 ` [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Lee Jones
2020-11-02 11:44 ` Lee Jones [this message]
2020-11-02 11:44 ` [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 08/30] net: fddi: skfp: queue: " Lee Jones
2020-11-02 11:44 ` [PATCH 09/30] net: fddi: skfp: rmt: " Lee Jones
2020-11-02 11:44 ` [PATCH 10/30] net: fddi: skfp: smtdef: " Lee Jones
2020-11-02 11:44 ` [PATCH 11/30] net: fddi: skfp: smtinit: " Lee Jones
2020-11-02 11:44 ` [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Lee Jones
2020-11-02 11:44 ` [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Lee Jones
2020-11-02 11:44 ` [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:44 ` [PATCH 15/30] net: fddi: skfp: hwt: " Lee Jones
2020-11-02 11:44 ` [PATCH 16/30] net: fddi: skfp: srf: " Lee Jones
2020-11-02 11:44 ` [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Lee Jones
2020-11-02 11:45 ` [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Lee Jones
2020-11-02 11:45 ` [PATCH 19/30] net: fddi: skfp: ess: " Lee Jones
2020-11-02 11:45 ` [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Lee Jones
2020-11-03 16:18 ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Lee Jones
2020-11-02 11:45 ` [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Lee Jones
2020-11-02 12:06 ` Hayes Wang
2020-11-02 11:45 ` [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Lee Jones
2020-11-03 16:19 ` Stefan Schmidt
2020-11-02 11:45 ` [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Lee Jones
2020-11-02 11:45 ` [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Lee Jones
2020-11-02 11:45 ` [PATCH 26/30] net: macvlan: Demote nonconformant function header Lee Jones
2020-11-02 11:45 ` [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Lee Jones
2020-11-02 12:06 ` Hayes Wang
2020-11-02 11:45 ` [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Lee Jones
2020-11-02 11:45 ` [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Lee Jones
2020-11-02 11:45 ` [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Lee Jones
2020-11-12 10:06 ` Lee Jones
2020-11-12 16:18 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102114512.1062724-7-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=davem@davemloft.net \
--cc=inaky.perez-gonzalez@intel.com \
--cc=kuba@kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yanirx.lubetkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).