From: Karsten Graul <kgraul@linux.ibm.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
hca@linux.ibm.com, raspl@linux.ibm.com
Subject: [PATCH net-next v2 03/15] net/smc: Add connection counters for links
Date: Tue, 3 Nov 2020 11:25:19 +0100 [thread overview]
Message-ID: <20201103102531.91710-4-kgraul@linux.ibm.com> (raw)
In-Reply-To: <20201103102531.91710-1-kgraul@linux.ibm.com>
From: Guvenc Gulce <guvenc@linux.ibm.com>
Add connection counters to the structure of the link.
Increase/decrease the counters as needed in the corresponding
routines.
Signed-off-by: Guvenc Gulce <guvenc@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
---
net/smc/smc_core.c | 16 ++++++++++++++--
net/smc/smc_core.h | 1 +
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
index 2b19863f7171..6e2077161267 100644
--- a/net/smc/smc_core.c
+++ b/net/smc/smc_core.c
@@ -139,6 +139,7 @@ static int smcr_lgr_conn_assign_link(struct smc_connection *conn, bool first)
}
if (!conn->lnk)
return SMC_CLC_DECL_NOACTLINK;
+ atomic_inc(&conn->lnk->conn_cnt);
return 0;
}
@@ -180,6 +181,8 @@ static void __smc_lgr_unregister_conn(struct smc_connection *conn)
struct smc_link_group *lgr = conn->lgr;
rb_erase(&conn->alert_node, &lgr->conns_all);
+ if (conn->lnk)
+ atomic_dec(&conn->lnk->conn_cnt);
lgr->conns_num--;
conn->alert_token_local = 0;
sock_put(&smc->sk); /* sock_hold in smc_lgr_register_conn() */
@@ -314,6 +317,7 @@ int smcr_link_init(struct smc_link_group *lgr, struct smc_link *lnk,
lnk->smcibdev = ini->ib_dev;
lnk->ibport = ini->ib_port;
lnk->path_mtu = ini->ib_dev->pattr[ini->ib_port - 1].active_mtu;
+ atomic_set(&lnk->conn_cnt, 0);
smc_llc_link_set_uid(lnk);
INIT_WORK(&lnk->link_down_wrk, smc_link_down_work);
if (!ini->ib_dev->initialized) {
@@ -526,6 +530,14 @@ static int smc_switch_cursor(struct smc_sock *smc, struct smc_cdc_tx_pend *pend,
return rc;
}
+static inline void smc_switch_link_and_count(struct smc_connection *conn,
+ struct smc_link *to_lnk)
+{
+ atomic_dec(&conn->lnk->conn_cnt);
+ conn->lnk = to_lnk;
+ atomic_inc(&conn->lnk->conn_cnt);
+}
+
struct smc_link *smc_switch_conns(struct smc_link_group *lgr,
struct smc_link *from_lnk, bool is_dev_err)
{
@@ -574,7 +586,7 @@ struct smc_link *smc_switch_conns(struct smc_link_group *lgr,
smc->sk.sk_state == SMC_PEERABORTWAIT ||
smc->sk.sk_state == SMC_PROCESSABORT) {
spin_lock_bh(&conn->send_lock);
- conn->lnk = to_lnk;
+ smc_switch_link_and_count(conn, to_lnk);
spin_unlock_bh(&conn->send_lock);
continue;
}
@@ -588,7 +600,7 @@ struct smc_link *smc_switch_conns(struct smc_link_group *lgr,
}
/* avoid race with smcr_tx_sndbuf_nonempty() */
spin_lock_bh(&conn->send_lock);
- conn->lnk = to_lnk;
+ smc_switch_link_and_count(conn, to_lnk);
rc = smc_switch_cursor(smc, pend, wr_buf);
spin_unlock_bh(&conn->send_lock);
sock_put(&smc->sk);
diff --git a/net/smc/smc_core.h b/net/smc/smc_core.h
index 9aee54a6bcba..83a88a4635db 100644
--- a/net/smc/smc_core.h
+++ b/net/smc/smc_core.h
@@ -129,6 +129,7 @@ struct smc_link {
struct delayed_work llc_testlink_wrk; /* testlink worker */
struct completion llc_testlink_resp; /* wait for rx of testlink */
int llc_testlink_time; /* testlink interval */
+ atomic_t conn_cnt;
};
/* For now we just allow one parallel link per link group. The SMC protocol
--
2.17.1
next prev parent reply other threads:[~2020-11-03 10:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 10:25 [PATCH net-next v2 00/15] net/smc: extend diagnostic netlink interface Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 01/15] net/smc: use helper smc_conn_abort() in listen processing Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 02/15] net/smc: Use active link of the connection Karsten Graul
2020-11-03 10:25 ` Karsten Graul [this message]
2020-11-03 10:25 ` [PATCH net-next v2 04/15] net/smc: Add link counters for IB device ports Karsten Graul
2020-11-04 0:52 ` Saeed Mahameed
2020-11-03 10:25 ` [PATCH net-next v2 05/15] net/smc: Add diagnostic information to smc ib-device Karsten Graul
2020-11-04 1:00 ` Saeed Mahameed
2020-11-03 10:25 ` [PATCH net-next v2 06/15] net/smc: Add diagnostic information to link structure Karsten Graul
2020-11-04 1:06 ` Saeed Mahameed
2020-11-03 10:25 ` [PATCH net-next v2 07/15] net/smc: Refactor the netlink reply processing routine Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 08/15] net/smc: Add ability to work with extended SMC netlink API Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 09/15] net/smc: Introduce SMCR get linkgroup command Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 10/15] net/smc: Introduce SMCR get link command Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 11/15] net/smc: Add SMC-D Linkgroup diagnostic support Karsten Graul
2020-11-04 1:26 ` Saeed Mahameed
2020-11-03 10:25 ` [PATCH net-next v2 12/15] net/smc: Add support for obtaining SMCD device list Karsten Graul
2020-11-04 1:31 ` Saeed Mahameed
2020-11-06 6:38 ` Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 13/15] net/smc: Add support for obtaining SMCR " Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 14/15] net/smc: Refactor smc ism v2 capability handling Karsten Graul
2020-11-03 10:25 ` [PATCH net-next v2 15/15] net/smc: Add support for obtaining system information Karsten Graul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103102531.91710-4-kgraul@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).