From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>,
Christian Eggers <ceggers@arri.de>,
Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH v3 net-next 09/12] net: dsa: tag_brcm: let DSA core deal with TX reallocation
Date: Tue, 3 Nov 2020 10:51:00 +0000 [thread overview]
Message-ID: <20201103105059.t66xhok5elgx4r4h@skbuf> (raw)
In-Reply-To: <10537403-67a4-c64a-705a-61bc5f55f80e@gmail.com>
On Mon, Nov 02, 2020 at 12:34:11PM -0800, Florian Fainelli wrote:
> On 11/1/2020 11:16 AM, Vladimir Oltean wrote:
> > Now that we have a central TX reallocation procedure that accounts for
> > the tagger's needed headroom in a generic way, we can remove the
> > skb_cow_head call.
> >
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Florian, I just noticed that tag_brcm.c has an __skb_put_padto call,
even though it is not a tail tagger. This comes from commit:
commit bf08c34086d159edde5c54902dfa2caa4d9fbd8c
Author: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed Jan 3 22:13:00 2018 -0800
net: dsa: Move padding into Broadcom tagger
Instead of having the different master network device drivers
potentially used by DSA/Broadcom tags, move the padding necessary for
the switches to accept short packets where it makes most sense: within
tag_brcm.c. This avoids multiplying the number of similar commits to
e.g: bgmac, bcmsysport, etc.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Do you remember why this was needed?
As far as I understand, either the DSA master driver or the MAC itself
should pad frames automatically. Is that not happening on Broadcom SoCs,
or why do you need to pad from DSA?
How should we deal with this? Having tag_brcm.c still do some potential
reallocation defeats the purpose of doing it centrally, in a way. I was
trying to change the prototype of struct dsa_device_ops::xmit to stop
returning a struct sk_buff *, and I stumbled upon this.
Should we just go ahead and pad everything unconditionally in DSA?
next prev parent reply other threads:[~2020-11-03 10:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 19:16 [PATCH v3 net-next 00/12] Generic TX reallocation for DSA Vladimir Oltean
2020-11-01 19:16 ` [PATCH v3 net-next 01/12] net: dsa: implement a central TX reallocation procedure Vladimir Oltean
2020-11-02 20:43 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 02/12] net: dsa: tag_ksz: don't allocate additional memory for padding/tagging Vladimir Oltean
2020-11-02 20:44 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 03/12] net: dsa: trailer: " Vladimir Oltean
2020-11-02 20:44 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 04/12] net: dsa: tag_qca: let DSA core deal with TX reallocation Vladimir Oltean
2020-11-02 20:45 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 05/12] net: dsa: tag_ocelot: " Vladimir Oltean
2020-11-02 20:45 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 06/12] net: dsa: tag_mtk: " Vladimir Oltean
2020-11-02 20:45 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 07/12] net: dsa: tag_lan9303: " Vladimir Oltean
2020-11-02 20:51 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 08/12] net: dsa: tag_edsa: " Vladimir Oltean
2020-11-02 20:51 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 09/12] net: dsa: tag_brcm: " Vladimir Oltean
2020-11-02 20:34 ` Florian Fainelli
2020-11-03 10:51 ` Vladimir Oltean [this message]
2020-11-03 17:04 ` Jakub Kicinski
2020-11-03 18:15 ` Vladimir Oltean
2020-11-03 18:34 ` Jakub Kicinski
2020-11-03 17:32 ` Florian Fainelli
2020-11-03 18:00 ` Vladimir Oltean
2020-11-01 19:16 ` [PATCH v3 net-next 10/12] net: dsa: tag_dsa: " Vladimir Oltean
2020-11-02 20:52 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 11/12] net: dsa: tag_gswip: " Vladimir Oltean
2020-11-02 20:52 ` Florian Fainelli
2020-11-01 19:16 ` [PATCH v3 net-next 12/12] net: dsa: tag_ar9331: " Vladimir Oltean
2020-11-02 20:52 ` Florian Fainelli
2020-11-03 1:43 ` [PATCH v3 net-next 00/12] Generic TX reallocation for DSA Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103105059.t66xhok5elgx4r4h@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=ceggers@arri.de \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox