From: Kalle Valo <kvalo@codeaurora.org>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: unlisted-recipients:; (no To-header on input) Alex Dewar
<alex.dewar90@gmail.com>, Saeed Mahameed <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop
Date: Fri, 6 Nov 2020 06:36:00 +0000 (UTC) [thread overview]
Message-ID: <20201106063600.91670C433FF@smtp.codeaurora.org> (raw)
In-Reply-To: <20200916165748.20927-1-alex.dewar90@gmail.com>
Alex Dewar <alex.dewar90@gmail.com> wrote:
> The for loop checks whether cur_section is NULL on every iteration, but
> we know it can never be NULL as there is another check towards the
> bottom of the loop body. Refactor to avoid this unnecessary check.
>
> Also, increment the variable i inline for clarity
>
> Addresses-Coverity: 1496984 ("Null pointer dereferences)
> Suggested-by: Saeed Mahameed <saeedm@nvidia.com>
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
dbeb101d28eb ath10k: sdio: remove redundant check in for loop
--
https://patchwork.kernel.org/project/linux-wireless/patch/20200916165748.20927-1-alex.dewar90@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-06 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 19:19 [PATCH] ath10k: sdio: remove reduntant check in for loop Alex Dewar
2020-09-14 21:51 ` Saeed Mahameed
2020-09-16 16:57 ` [PATCH v2] ath10k: sdio: remove redundant " Alex Dewar
2020-09-17 0:45 ` Julian Calaby
2020-09-24 16:27 ` Kalle Valo
2020-09-27 10:58 ` Alex Dewar
2020-09-29 7:42 ` Kalle Valo
2020-11-06 6:36 ` Kalle Valo [this message]
2020-09-16 16:59 ` [PATCH] ath10k: sdio: remove reduntant " Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106063600.91670C433FF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=alex.dewar90@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).