From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@gmail.com,
jiri@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next 05/18] rtnetlink: Add RTNH_F_TRAP flag
Date: Mon, 9 Nov 2020 17:35:50 +0200 [thread overview]
Message-ID: <20201109153550.GA1796533@shredder> (raw)
In-Reply-To: <20201106111221.06e16716@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Nov 06, 2020 at 11:12:21AM -0800, Jakub Kicinski wrote:
> On Wed, 4 Nov 2020 15:30:27 +0200 Ido Schimmel wrote:
> > *flags |= (nhc->nhc_flags & RTNH_F_ONLINK);
> > if (nhc->nhc_flags & RTNH_F_OFFLOAD)
> > *flags |= RTNH_F_OFFLOAD;
> > + if (nhc->nhc_flags & RTNH_F_TRAP)
> > + *flags |= RTNH_F_TRAP;
>
> Out of curiosity - why use this if construct like OFFLOAD rather than
> the more concise mask like ONLINK does?
Good question :)
> In fact looks like the mask could just be extended there instead?
Yes, good suggestion. Will do that.
next prev parent reply other threads:[~2020-11-09 15:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 13:30 [PATCH net-next 00/18] nexthop: Add support for nexthop objects offload Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 01/18] nexthop: Add nexthop notification data structures Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 02/18] nexthop: Pass extack to nexthop notifier Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 03/18] nexthop: Prepare new notification info Ido Schimmel
2020-11-06 19:08 ` Jakub Kicinski
2020-11-04 13:30 ` [PATCH net-next 04/18] nexthop: vxlan: Convert to " Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 05/18] rtnetlink: Add RTNH_F_TRAP flag Ido Schimmel
2020-11-06 19:12 ` Jakub Kicinski
2020-11-09 15:35 ` Ido Schimmel [this message]
2020-11-04 13:30 ` [PATCH net-next 06/18] nexthop: Allow setting "offload" and "trap" indications on nexthops Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 07/18] nexthop: Emit a notification when a nexthop is added Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 08/18] nexthop: Emit a notification when a nexthop group is replaced Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 09/18] nexthop: Emit a notification when a single nexthop " Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 10/18] nexthop: Emit a notification when a nexthop group is modified Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 11/18] nexthop: Emit a notification when a nexthop group is reduced Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 12/18] nexthop: Pass extack to register_nexthop_notifier() Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 13/18] nexthop: Replay nexthops when registering a notifier Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 14/18] nexthop: Remove in-kernel route notifications when nexthop changes Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 15/18] netdevsim: Add devlink resource for nexthops Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 16/18] netdevsim: Add dummy implementation for nexthop offload Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 17/18] netdevsim: Allow programming routes with nexthop objects Ido Schimmel
2020-11-04 13:30 ` [PATCH net-next 18/18] selftests: netdevsim: Add test for nexthop offload API Ido Schimmel
2020-11-06 19:31 ` [PATCH net-next 00/18] nexthop: Add support for nexthop objects offload Jakub Kicinski
2020-11-09 15:41 ` Ido Schimmel
2020-11-10 3:48 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109153550.GA1796533@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox