From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: evgreen@chromium.org, subashab@codeaurora.org,
cpratapa@codeaurora.org, bjorn.andersson@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 4/4] net: ipa: drop an error message
Date: Mon, 9 Nov 2020 10:56:35 -0600 [thread overview]
Message-ID: <20201109165635.5449-5-elder@linaro.org> (raw)
In-Reply-To: <20201109165635.5449-1-elder@linaro.org>
There is no need for gsi_modem_channel_halt() to report an error,
because gsi_generic_command() will already have done that if the
command times out. So get rid of the extra message.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/gsi.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 961a11d4fb270..3a5998a037dab 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1661,12 +1661,7 @@ static int gsi_modem_channel_alloc(struct gsi *gsi, u32 channel_id)
static void gsi_modem_channel_halt(struct gsi *gsi, u32 channel_id)
{
- int ret;
-
- ret = gsi_generic_command(gsi, channel_id, GSI_GENERIC_HALT_CHANNEL);
- if (ret)
- dev_err(gsi->dev, "error %d halting modem channel %u\n",
- ret, channel_id);
+ (void)gsi_generic_command(gsi, channel_id, GSI_GENERIC_HALT_CHANNEL);
}
/* Setup function for channels */
--
2.20.1
next prev parent reply other threads:[~2020-11-09 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 16:56 [PATCH net-next 0/4] net: ipa: little fixes Alex Elder
2020-11-09 16:56 ` [PATCH net-next 1/4] net: ipa: don't break build on large transaction size Alex Elder
2020-11-09 16:56 ` [PATCH net-next 2/4] net: ipa: get rid of a useless line of code Alex Elder
2020-11-09 16:56 ` [PATCH net-next 3/4] net: ipa: change a warning to debug Alex Elder
2020-11-09 16:56 ` Alex Elder [this message]
2020-11-11 22:08 ` [PATCH net-next 0/4] net: ipa: little fixes Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109165635.5449-5-elder@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).