From: Andrew Lunn <andrew@lunn.ch>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags
Date: Mon, 9 Nov 2020 20:49:34 +0100 [thread overview]
Message-ID: <20201109194934.GE1456319@lunn.ch> (raw)
In-Reply-To: <20201109193117.2017-1-TheSven73@gmail.com>
> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -491,7 +491,9 @@ static int ks8995_probe(struct spi_device *spi)
>
> spi_set_drvdata(spi, ks);
>
> - spi->mode = SPI_MODE_0;
> + /* use SPI_MODE_0 without changing any other mode flags */
> + spi->mode &= ~(SPI_CPHA | SPI_CPOL);
> + spi->mode |= SPI_MODE_0;
> spi->bits_per_word = 8;
Did you check to see if there is a help to set just the mode without
changing any of the other bits?
Andrew
next prev parent reply other threads:[~2020-11-09 19:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 19:31 [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags Sven Van Asbroeck
2020-11-09 19:49 ` Andrew Lunn [this message]
2020-11-09 19:56 ` Sven Van Asbroeck
2020-11-09 20:25 ` Andrew Lunn
2020-11-09 20:34 ` Sven Van Asbroeck
2020-11-09 21:09 ` Jakub Kicinski
2020-11-09 21:20 ` Sven Van Asbroeck
2020-11-09 21:24 ` Jakub Kicinski
2020-11-09 21:29 ` Sven Van Asbroeck
2020-11-09 22:04 ` Jakub Kicinski
2020-11-09 22:19 ` Sven Van Asbroeck
2020-11-09 22:23 ` Jakub Kicinski
2020-11-09 22:27 ` Sven Van Asbroeck
2020-11-09 22:36 ` Jakub Kicinski
2020-11-09 22:39 ` Sven Van Asbroeck
2020-11-09 22:50 ` Jakub Kicinski
2020-11-09 22:57 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109194934.GE1456319@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).