From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>, Nicolas Pitre <nico@fluxnic.net>,
Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v3 net-next 4/7] drivers: net: smc911x: Fix set but unused status because of DBG macro
Date: Tue, 10 Nov 2020 04:02:45 +0100 [thread overview]
Message-ID: <20201110030248.1480413-5-andrew@lunn.ch> (raw)
In-Reply-To: <20201110030248.1480413-1-andrew@lunn.ch>
drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_timeout’:
drivers/net/ethernet/smsc/smc911x.c:1251:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
1251 | int status, mask;
The status is read in order to print it via the DBG macro. However,
due to the way DBG is disabled, the compiler never sees it being used.
Change the DBG macro to actually make use of the passed parameters,
and the leave the optimiser to remove the unwanted code inside the
while (0).
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/ethernet/smsc/smc911x.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c
index 8f748a0c057e..6978050496ac 100644
--- a/drivers/net/ethernet/smsc/smc911x.c
+++ b/drivers/net/ethernet/smsc/smc911x.c
@@ -102,7 +102,10 @@ MODULE_ALIAS("platform:smc911x");
#define PRINTK(dev, args...) netdev_info(dev, args)
#else
-#define DBG(n, dev, args...) do { } while (0)
+#define DBG(n, dev, args...) \
+ while (0) { \
+ netdev_dbg(dev, args); \
+ }
#define PRINTK(dev, args...) netdev_dbg(dev, args)
#endif
--
2.29.2
next prev parent reply other threads:[~2020-11-10 3:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 3:02 [PATCH v3 net-next 0/7] smsc W=1 warning fixes Andrew Lunn
2020-11-10 3:02 ` [PATCH v3 net-next 1/7] drivers: net: smc91x: Fix set but unused W=1 warning Andrew Lunn
2020-11-10 3:02 ` [PATCH v3 net-next 2/7] drivers: net: smc91x: Fix missing kerneldoc reported by W=1 Andrew Lunn
2020-11-10 3:02 ` [PATCH v3 net-next 3/7] drivers: net: smc911x: Work around set but unused status Andrew Lunn
2020-11-10 3:02 ` Andrew Lunn [this message]
2020-11-10 3:02 ` [PATCH v3 net-next 5/7] drivers: net: smc911x: Fix passing wrong number of parameters to DBG() macro Andrew Lunn
2020-11-10 3:02 ` [PATCH v3 net-next 6/7] drivers: net: smc911x: Fix cast from pointer to integer of different size Andrew Lunn
2020-11-10 3:02 ` [PATCH v3 net-next 7/7] drivers: net: smsc: Add COMPILE_TEST support Andrew Lunn
2020-11-12 22:51 ` [PATCH v3 net-next 0/7] smsc W=1 warning fixes Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110030248.1480413-5-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).