From: Miroslav Lichvar <mlichvar@redhat.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, andre.guedes@intel.com,
linux-pci@vger.kernel.org, netdev@vger.kernel.org,
bhelgaas@google.com
Subject: Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()
Date: Tue, 10 Nov 2020 19:07:19 +0100 [thread overview]
Message-ID: <20201110180719.GA1559650@localhost> (raw)
In-Reply-To: <20201110061019.519589-4-vinicius.gomes@intel.com>
On Mon, Nov 09, 2020 at 10:10:19PM -0800, Vinicius Costa Gomes wrote:
> i225 has support for PCIe PTM, which allows us to implement support
> for the PTP_SYS_OFFSET_PRECISE ioctl(), implemented in the driver via
> the getcrosststamp() function.
Would it be possible to provide the PTM measurements with the
PTP_SYS_OFFSET_EXTENDED ioctl instead of PTP_SYS_OFFSET_PRECISE?
As I understand it, PTM is not cross timestamping. It's basically
NTP over PCIe, which provides four timestamps with each "dialog". From
the other constants added to the header file it looks like they could
all be obtained and then they could be converted to the triplets
returned by the EXTENDED ioctl.
The main advantage would be that it would provide applications with
the round trip time, which is important to estimate the maximum error
in the measurement. As your example phc2sys output shows, with the
PRECISE ioctl the delay is 0, which is misleading here.
I suspect the estimate would be valid only when the NIC is connected
directly to the PTM root (PCI root complex). Is it possible to get the
timestamps or delay from PTM-capable switches on the path between CPU
and NIC? Also, how frequent can be the PTM dialogs? Could they be
performed synchronously in the ioctl?
--
Miroslav Lichvar
next prev parent reply other threads:[~2020-11-10 18:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 6:10 [PATCH next-queue v2 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes
2020-11-10 6:10 ` [PATCH next-queue v2 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2020-11-10 6:10 ` [PATCH next-queue v2 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes
2020-11-10 6:10 ` [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2020-11-10 18:07 ` Miroslav Lichvar [this message]
2020-11-10 19:06 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-11-11 9:33 ` Miroslav Lichvar
2020-11-11 22:23 ` Vinicius Costa Gomes
2020-11-12 9:32 ` Miroslav Lichvar
2020-11-12 23:46 ` Vinicius Costa Gomes
2020-11-13 3:24 ` Richard Cochran
2020-11-13 19:10 ` Vinicius Costa Gomes
2020-11-14 2:57 ` Richard Cochran
2020-11-17 1:06 ` Vinicius Costa Gomes
2020-11-17 1:49 ` Richard Cochran
2020-11-18 1:21 ` Vinicius Costa Gomes
2020-11-18 12:54 ` Richard Cochran
2020-11-19 0:22 ` Vinicius Costa Gomes
2020-11-20 14:16 ` Richard Cochran
2020-11-20 17:58 ` Vinicius Costa Gomes
2021-03-22 15:36 ` Vinicius Costa Gomes
2021-03-23 4:17 ` Richard Cochran
2020-11-18 15:55 ` Jakub Kicinski
2020-11-20 19:07 ` Vinicius Costa Gomes
2020-11-12 0:38 ` Vinicius Costa Gomes
2021-03-22 15:47 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110180719.GA1559650@localhost \
--to=mlichvar@redhat.com \
--cc=andre.guedes@intel.com \
--cc=bhelgaas@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).