From: Kalle Valo <kvalo@codeaurora.org>
To: Tsuchiya Yuto <kitakar@gmail.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi.bhat@nxp.com>,
Xinming Hu <huxinming820@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maximilian Luz <luzmaximilian@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
verdre@v0yd.nl, Tsuchiya Yuto <kitakar@gmail.com>
Subject: Re: [1/2] mwifiex: fix mwifiex_shutdown_sw() causing sw reset failure
Date: Tue, 10 Nov 2020 18:50:13 +0000 (UTC) [thread overview]
Message-ID: <20201110185013.36A35C433FE@smtp.codeaurora.org> (raw)
In-Reply-To: <20201028142110.18144-2-kitakar@gmail.com>
Tsuchiya Yuto <kitakar@gmail.com> wrote:
> When a PCIe function level reset (FLR) is performed but without fw reset for
> some reasons (e.g., on Microsoft Surface devices, fw reset requires other
> quirks), it fails to reset wifi properly. You can trigger the issue on such
> devices via debugfs entry for reset:
>
> $ echo 1 | sudo tee /sys/kernel/debug/mwifiex/mlan0/reset
>
> and the resulting dmesg log:
>
> [ 45.740508] mwifiex_pcie 0000:03:00.0: Resetting per request
> [ 45.742937] mwifiex_pcie 0000:03:00.0: info: successfully disconnected from [BSSID]: reason code 3
> [ 45.744666] mwifiex_pcie 0000:03:00.0: info: shutdown mwifiex...
> [ 45.751530] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.751539] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771691] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771695] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 45.771697] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771698] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 45.771699] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771701] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 45.771702] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771703] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 45.771704] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771705] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 45.771707] mwifiex_pcie 0000:03:00.0: PREP_CMD: card is removed
> [ 45.771708] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 53.099343] mwifiex_pcie 0000:03:00.0: info: trying to associate to '[SSID]' bssid [BSSID]
> [ 53.241870] mwifiex_pcie 0000:03:00.0: info: associated to bssid [BSSID] successfully
> [ 75.377942] mwifiex_pcie 0000:03:00.0: cmd_wait_q terminated: -110
> [ 85.385491] mwifiex_pcie 0000:03:00.0: info: successfully disconnected from [BSSID]: reason code 15
> [ 87.539408] mwifiex_pcie 0000:03:00.0: cmd_wait_q terminated: -110
> [ 87.539412] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 99.699917] mwifiex_pcie 0000:03:00.0: cmd_wait_q terminated: -110
> [ 99.699925] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [ 111.859802] mwifiex_pcie 0000:03:00.0: cmd_wait_q terminated: -110
> [ 111.859808] mwifiex_pcie 0000:03:00.0: deleting the crypto keys
> [...]
>
> When comparing mwifiex_shutdown_sw() with mwifiex_pcie_remove(), it
> lacks mwifiex_init_shutdown_fw().
>
> This commit fixes mwifiex_shutdown_sw() by adding the missing
> mwifiex_init_shutdown_fw().
>
> Fixes: 4c5dae59d2e9 ("mwifiex: add PCIe function level reset support")
> Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
2 patches applied to wireless-drivers-next.git, thanks.
fa74cb1dc0f4 mwifiex: fix mwifiex_shutdown_sw() causing sw reset failure
566b4cb9587e mwifiex: update comment for shutdown_sw()/reinit_sw() to reflect current state
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201028142110.18144-2-kitakar@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-10 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 14:21 [PATCH 0/2] mwifiex: fixes for shutdown_sw() and reinit_sw() Tsuchiya Yuto
2020-10-28 14:21 ` [PATCH 1/2] mwifiex: fix mwifiex_shutdown_sw() causing sw reset failure Tsuchiya Yuto
2020-11-08 11:31 ` Kalle Valo
2020-11-08 12:19 ` Tsuchiya Yuto
2020-11-10 18:50 ` Kalle Valo [this message]
2020-10-28 14:21 ` [PATCH 2/2] mwifiex: update comment for shutdown_sw()/reinit_sw() to reflect current state Tsuchiya Yuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110185013.36A35C433FE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=davem@davemloft.net \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).