From: Anmol Karn <anmol.karan123@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ralf@linux-mips.org, davem@davemloft.net, saeed@kernel.org,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
syzkaller-bugs@googlegroups.com,
syzbot+a1c743815982d9496393@syzkaller.appspotmail.com
Subject: Re: [Linux-kernel-mentees] [PATCH v3 net] rose: Fix Null pointer dereference in rose_send_frame()
Date: Wed, 11 Nov 2020 01:15:18 +0530 [thread overview]
Message-ID: <20201110194518.GA97719@Thinkpad> (raw)
In-Reply-To: <20201110095815.41577920@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hello Sir,
On Tue, Nov 10, 2020 at 09:58:15AM -0800, Jakub Kicinski wrote:
> On Sun, 8 Nov 2020 00:48:35 +0530 Anmol Karn wrote:
> > + dev = rose_dev_get(dest);
>
> this calls dev_hold internally, you never release that reference in
> case ..neigh->dev is NULL
>
> > + if (rose_loopback_neigh->dev && dev) {
Ah, I missed to `dev_put()` the `dev` after checking for, if neigh->dev is NULL,
I will fix it soon and send another version.
Thank you for review.
Anmol
next prev parent reply other threads:[~2020-11-10 19:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:56 [Linux-kernel-mentees] [PATCH v2 net] rose: Fix Null pointer dereference in rose_send_frame() Anmol Karn
2020-11-06 21:04 ` Saeed Mahameed
2020-11-07 8:20 ` Anmol Karn
2020-11-07 19:18 ` [Linux-kernel-mentees] [PATCH v3 " Anmol Karn
2020-11-10 17:58 ` Jakub Kicinski
2020-11-10 19:45 ` Anmol Karn [this message]
2020-11-11 16:59 ` [Linux-kernel-mentees] [PATCH v4 " Anmol Karn
2020-11-14 19:18 ` Jakub Kicinski
2020-11-15 11:44 ` Anmol Karn
2020-11-19 19:10 ` [Linux-kernel-mentees] [PATCH v5 " Anmol Karn
2020-11-20 18:06 ` Jakub Kicinski
2020-11-07 18:56 ` [Linux-kernel-mentees] [PATCH v2] net: " Anmol Karn
2020-11-07 19:02 ` Anmol karn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110194518.GA97719@Thinkpad \
--to=anmol.karan123@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=saeed@kernel.org \
--cc=syzbot+a1c743815982d9496393@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).