From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C852DC4742C for ; Wed, 11 Nov 2020 10:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D32220756 for ; Wed, 11 Nov 2020 10:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZnvTuVK5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726036AbgKKKum (ORCPT ); Wed, 11 Nov 2020 05:50:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50140 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgKKKuj (ORCPT ); Wed, 11 Nov 2020 05:50:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605091838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mnA7XsiGSJFXhW6YNgCg1O0O0+tMAkowMzr0RmATALo=; b=ZnvTuVK5FsVtsj2ls3L/0j1BBP2vJyBJjMhgaPFm6y6lcyHGhJ2JGCo0xgQ+RR4vcgHZdq wB/sdqf4X/BbGI5m4qwy+vBkYecNF0kf9GjMQaiA9cHHtY4ne8deTWlDNNHHgzkIaCPiPg gF1Z1MWx7XWKB0d/hyLmtOyppTGU6NE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-djZF94KbOROneZUeruj-9A-1; Wed, 11 Nov 2020 05:50:36 -0500 X-MC-Unique: djZF94KbOROneZUeruj-9A-1 Received: by mail-wr1-f72.google.com with SMTP id h11so455203wrq.20 for ; Wed, 11 Nov 2020 02:50:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mnA7XsiGSJFXhW6YNgCg1O0O0+tMAkowMzr0RmATALo=; b=gkZTHqYam0Mq1De5M5/P0UMTvrFsGkmDZA1O2/HZC8eq4iveJSj0jNrij+GQlZzJyx Sph0qUaJnBqIyMJqPl7Pi2ZhbB6rzE5eInXo4Udl4zQM9fN02ncHzx1eXTdGO2+nJMjH nO7HYlH5TTfwJ7LZqM5j14gd5V6B1vOSlCZc/s0j5/M60cIOAo4H2XYtbcGpNRmi6VGz SMwvpJOWhchSxxRlo6zImvCCy02SsWxYhmm/rzYTsUGhtiivTxlBd57ufuK3YimXPiYv aejzlwuOaNN3GjINNDmFhNrmy5OwMSwrUcaVFNORK4KqSAXUkMlVIHmNQqqhhelMIuHa cB2g== X-Gm-Message-State: AOAM530jGQlRJ0xzPhhPigZbJd+SIhDa1oMQvYxDjmh2Nxutth6wQpSy tGbYEkFT842ThDAJhIkSqgZk+kzin1yUCtd0fQPQZMWqYlBsqEFgD9xuRhmguulj4cgfnO4l9um NIr1pqCRY0+WJyL1z X-Received: by 2002:adf:eeca:: with SMTP id a10mr24970190wrp.186.1605091835503; Wed, 11 Nov 2020 02:50:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxz4TPJxgCHN7vv+R3d7jzN9KDvG9vgiS4za2+hlcdJRS27vg4GofYWp6iFMLk0C1lnkV/R+w== X-Received: by 2002:adf:eeca:: with SMTP id a10mr24970172wrp.186.1605091835295; Wed, 11 Nov 2020 02:50:35 -0800 (PST) Received: from steredhat (host-79-47-126-226.retail.telecomitalia.it. [79.47.126.226]) by smtp.gmail.com with ESMTPSA id p4sm2017826wrm.51.2020.11.11.02.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 02:50:34 -0800 (PST) Date: Wed, 11 Nov 2020 11:50:31 +0100 From: Stefano Garzarella To: Tian Tao Cc: mst@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vhost_vdpa: switch to vmemdup_user() Message-ID: <20201111105031.mtdbvt7grkxeuwn4@steredhat> References: <1605057288-60400-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1605057288-60400-1-git-send-email-tiantao6@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 11, 2020 at 09:14:48AM +0800, Tian Tao wrote: >Replace opencoded alloc and copy with vmemdup_user() > >Signed-off-by: Tian Tao >--- > drivers/vhost/vdpa.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Stefano Garzarella > >diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >index 2754f30..4c39583 100644 >--- a/drivers/vhost/vdpa.c >+++ b/drivers/vhost/vdpa.c >@@ -245,14 +245,10 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > return -EFAULT; > if (vhost_vdpa_config_validate(v, &config)) > return -EINVAL; >- buf = kvzalloc(config.len, GFP_KERNEL); >- if (!buf) >- return -ENOMEM; > >- if (copy_from_user(buf, c->buf, config.len)) { >- kvfree(buf); >- return -EFAULT; >- } >+ buf = vmemdup_user(c->buf, config.len); >+ if (IS_ERR(buf)) >+ return PTR_ERR(buf); > > ops->set_config(vdpa, config.off, buf, config.len); > >-- >2.7.4 >