From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: brouer@redhat.com, Jesper Dangaard Brouer <hawk@kernel.org>,
Vincent Bernat <vincent@bernat.ch>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next v2 2/3] net: evaluate net.ipv4.conf.all.proxy_arp_pvlan
Date: Thu, 12 Nov 2020 08:44:37 +0100 [thread overview]
Message-ID: <20201112084437.37d159e0@carbon> (raw)
In-Reply-To: <20201110152118.3636794d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Tue, 10 Nov 2020 15:21:18 -0800
Jakub Kicinski <kuba@kernel.org> wrote:
> On Sat, 7 Nov 2020 20:35:14 +0100 Vincent Bernat wrote:
> > Introduced in 65324144b50b, the "proxy_arp_vlan" sysctl is a
^ pvlan
The sysctl is called "proxy_arp_pvlan"
> > per-interface sysctl to tune proxy ARP support for private VLANs.
> > While the "all" variant is exposed, it was a noop and never evaluated.
> > We use the usual "or" logic for this kind of sysctls.
> >
> > Fixes: 65324144b50b ("net: RFC3069, private VLAN proxy arp support")
> > Signed-off-by: Vincent Bernat <vincent@bernat.ch>
> > ---
> > include/linux/inetdevice.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> CC Jesper
>
> I know this is 10 year old code, but can we get an ack for applying
> this to net-next?
ACK, I agree that the "all" variant doesn't make sense for proxy_arp_pvlan.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> > diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h
> > index 3bbcddd22df8..53aa0343bf69 100644
> > --- a/include/linux/inetdevice.h
> > +++ b/include/linux/inetdevice.h
> > @@ -105,7 +105,7 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev)
> >
> > #define IN_DEV_LOG_MARTIANS(in_dev) IN_DEV_ORCONF((in_dev), LOG_MARTIANS)
> > #define IN_DEV_PROXY_ARP(in_dev) IN_DEV_ORCONF((in_dev), PROXY_ARP)
> > -#define IN_DEV_PROXY_ARP_PVLAN(in_dev) IN_DEV_CONF_GET(in_dev, PROXY_ARP_PVLAN)
> > +#define IN_DEV_PROXY_ARP_PVLAN(in_dev) IN_DEV_ORCONF((in_dev), PROXY_ARP_PVLAN)
> > #define IN_DEV_SHARED_MEDIA(in_dev) IN_DEV_ORCONF((in_dev), SHARED_MEDIA)
> > #define IN_DEV_TX_REDIRECTS(in_dev) IN_DEV_ORCONF((in_dev), SEND_REDIRECTS)
> > #define IN_DEV_SEC_REDIRECTS(in_dev) IN_DEV_ORCONF((in_dev), \
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-11-12 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 19:35 net: evaluate net.ipvX.conf.all.* sysctls Vincent Bernat
2020-11-07 19:35 ` [PATCH net-next v2 1/3] net: evaluate net.ipvX.conf.all.ignore_routes_with_linkdown Vincent Bernat
2020-11-07 19:35 ` [PATCH net-next v2 2/3] net: evaluate net.ipv4.conf.all.proxy_arp_pvlan Vincent Bernat
2020-11-10 23:21 ` Jakub Kicinski
2020-11-12 7:44 ` Jesper Dangaard Brouer [this message]
2020-11-07 19:35 ` [PATCH net-next v2 3/3] net: evaluate net.ipvX.conf.all.disable_policy and disable_xfrm Vincent Bernat
2020-11-10 23:18 ` Jakub Kicinski
2020-11-12 0:43 ` net: evaluate net.ipvX.conf.all.* sysctls Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112084437.37d159e0@carbon \
--to=brouer@redhat.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=vincent@bernat.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox