From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E00FBC388F7 for ; Fri, 13 Nov 2020 08:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95A4E217A0 for ; Fri, 13 Nov 2020 08:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbgKMIQB (ORCPT ); Fri, 13 Nov 2020 03:16:01 -0500 Received: from muru.com ([72.249.23.125]:48202 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgKMIQB (ORCPT ); Fri, 13 Nov 2020 03:16:01 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A87178096; Fri, 13 Nov 2020 08:16:05 +0000 (UTC) Date: Fri, 13 Nov 2020 10:15:56 +0200 From: Tony Lindgren To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Jakub Kicinski , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Vignesh Raghavendra Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend Message-ID: <20201113081556.GW26857@atomide.com> References: <20201112111546.20343-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112111546.20343-1-grygorii.strashko@ti.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Grygorii Strashko [201112 11:15]: > Depending on the SoC/platform the CPSW can completely lose context after a > suspend/resume cycle, including CPSW wrapper (WR) which will cause reset of > WR_C0_MISC_EN register, so CPTS IRQ will became disabled. > > Fix it by moving CPTS IRQ enabling in cpsw_ndo_open() where CPTS is > actually started. > > Fixes: 84ea9c0a95d7 ("net: ethernet: ti: cpsw: enable cpts irq") > Reported-by: Tony Lindgren > Signed-off-by: Grygorii Strashko Thanks this works for me: Tested-by: Tony Lindgren