From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tobias Waldekranz <tobias@waldekranz.com>,
davem@davemloft.net, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers
Date: Sat, 14 Nov 2020 02:56:33 +0200 [thread overview]
Message-ID: <20201114005633.axcb6sc5qddycsuy@skbuf> (raw)
In-Reply-To: <20201113162709.608406b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Nov 13, 2020 at 04:27:09PM -0800, Jakub Kicinski wrote:
> On Wed, 11 Nov 2020 14:11:52 +0100 Tobias Waldekranz wrote:
> > Ethertype DSA encodes exactly the same information in the DSA tag as
> > the non-ethertype variety. So refactor out the common parts and reuse
> > them for both protocols.
> >
> > This is ensures tag parsing and generation is always consistent across
> > all mv88e6xxx chips.
> >
> > While we are at it, explicitly deal with all possible CPU codes on
> > receive, making sure to set offload_fwd_mark as appropriate.
>
> Uncharacteristically unreviewed for a DSA patch :)
Yeah, I don't know what happened...
next prev parent reply other threads:[~2020-11-14 0:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 13:11 [PATCH v2 net-next 0/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers Tobias Waldekranz
2020-11-11 13:11 ` [PATCH v2 net-next 1/2] " Tobias Waldekranz
2020-11-14 0:27 ` Jakub Kicinski
2020-11-14 0:56 ` Vladimir Oltean [this message]
2020-11-14 1:03 ` Vladimir Oltean
2020-11-14 2:08 ` Andrew Lunn
2020-11-14 11:29 ` Tobias Waldekranz
2020-11-14 12:20 ` Vladimir Oltean
2020-11-14 12:36 ` Tobias Waldekranz
2020-11-14 15:44 ` Andrew Lunn
2020-11-14 19:55 ` Tobias Waldekranz
2020-11-11 13:11 ` [PATCH v2 net-next 2/2] net: dsa: tag_dsa: Use a consistent comment style Tobias Waldekranz
2020-11-14 1:04 ` Vladimir Oltean
2020-11-14 2:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114005633.axcb6sc5qddycsuy@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox