* [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code. [not found] <CGME20201114002134epcms2p1b504111777f3b1be7a0d1706882a5237@epcms2p1> @ 2020-11-14 0:21 ` Bongsu Jeon 2020-11-14 10:08 ` krzk 0 siblings, 1 reply; 4+ messages in thread From: Bongsu Jeon @ 2020-11-14 0:21 UTC (permalink / raw) To: kuba@kernel.org, krzk@kernel.org, Krzysztof Opasiak Cc: netdev@vger.kernel.org ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> --- drivers/nfc/s3fwrn5/s3fwrn5.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h index 9d5f34759225..bb8f936d13a2 100644 --- a/drivers/nfc/s3fwrn5/s3fwrn5.h +++ b/drivers/nfc/s3fwrn5/s3fwrn5.h @@ -44,7 +44,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, enum s3fwrn5_mode mode) { if (!info->phy_ops->set_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_mode(info->phy_id, mode); @@ -54,7 +54,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) { if (!info->phy_ops->get_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->get_mode(info->phy_id); } @@ -62,7 +62,7 @@ static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) { if (!info->phy_ops->set_wake) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_wake(info->phy_id, wake); @@ -72,7 +72,7 @@ static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) static inline int s3fwrn5_write(struct s3fwrn5_info *info, struct sk_buff *skb) { if (!info->phy_ops->write) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->write(info->phy_id, skb); } -- ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code. 2020-11-14 0:21 ` [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code Bongsu Jeon @ 2020-11-14 10:08 ` krzk 0 siblings, 0 replies; 4+ messages in thread From: krzk @ 2020-11-14 10:08 UTC (permalink / raw) To: Bongsu Jeon; +Cc: kuba@kernel.org, Krzysztof Opasiak, netdev@vger.kernel.org On Sat, Nov 14, 2020 at 09:21:34AM +0900, Bongsu Jeon wrote: > > ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. The same as in patch #1 - trailing dot a subject end empty line at beginning of commit. Please CC all required maintainers and lists when submitting patches. You skipped here LKML and the most important - NFC mailing list. Use the scripts/get_maintainer.pl to get the necessary addresses. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CGME20201116011950epcms2p68117cc4a7228db2baecb7d4a4840b955@epcms2p6>]
* [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code [not found] <CGME20201116011950epcms2p68117cc4a7228db2baecb7d4a4840b955@epcms2p6> @ 2020-11-16 1:19 ` Bongsu Jeon 2020-11-16 9:08 ` krzk 0 siblings, 1 reply; 4+ messages in thread From: Bongsu Jeon @ 2020-11-16 1:19 UTC (permalink / raw) To: krzk@kernel.org, Krzysztof Opasiak Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> --- drivers/nfc/s3fwrn5/s3fwrn5.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h index 9d5f34759225..bb8f936d13a2 100644 --- a/drivers/nfc/s3fwrn5/s3fwrn5.h +++ b/drivers/nfc/s3fwrn5/s3fwrn5.h @@ -44,7 +44,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, enum s3fwrn5_mode mode) { if (!info->phy_ops->set_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_mode(info->phy_id, mode); @@ -54,7 +54,7 @@ static inline int s3fwrn5_set_mode(struct s3fwrn5_info *info, static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) { if (!info->phy_ops->get_mode) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->get_mode(info->phy_id); } @@ -62,7 +62,7 @@ static inline enum s3fwrn5_mode s3fwrn5_get_mode(struct s3fwrn5_info *info) static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) { if (!info->phy_ops->set_wake) - return -ENOTSUPP; + return -EOPNOTSUPP; info->phy_ops->set_wake(info->phy_id, wake); @@ -72,7 +72,7 @@ static inline int s3fwrn5_set_wake(struct s3fwrn5_info *info, bool wake) static inline int s3fwrn5_write(struct s3fwrn5_info *info, struct sk_buff *skb) { if (!info->phy_ops->write) - return -ENOTSUPP; + return -EOPNOTSUPP; return info->phy_ops->write(info->phy_id, skb); } -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code 2020-11-16 1:19 ` Bongsu Jeon @ 2020-11-16 9:08 ` krzk 0 siblings, 0 replies; 4+ messages in thread From: krzk @ 2020-11-16 9:08 UTC (permalink / raw) To: Bongsu Jeon Cc: Krzysztof Opasiak, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Nov 16, 2020 at 10:19:50AM +0900, Bongsu Jeon wrote: > ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > --- > drivers/nfc/s3fwrn5/s3fwrn5.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-16 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20201114002134epcms2p1b504111777f3b1be7a0d1706882a5237@epcms2p1>
2020-11-14 0:21 ` [PATCH net-next 3/3] nfc: s3fwrn5: Change the error code Bongsu Jeon
2020-11-14 10:08 ` krzk
[not found] <CGME20201116011950epcms2p68117cc4a7228db2baecb7d4a4840b955@epcms2p6>
2020-11-16 1:19 ` Bongsu Jeon
2020-11-16 9:08 ` krzk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).