From: "Marek Behún" <kabel@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "David S . Miller" <davem@davemloft.net>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Michal Hrusecki" <Michal.Hrusecky@nic.cz>,
"Tomas Hlavacek" <tomas.hlavacek@nic.cz>,
"Bedřicha Košatu" <bedrich.kosata@nic.cz>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Andrew Lunn" <andrew@lunn.ch>,
"Jason Cooper" <jason@lakedaemon.net>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy
Date: Sun, 15 Nov 2020 09:48:27 +0100 [thread overview]
Message-ID: <20201115094827.74eacbc3@kernel.org> (raw)
In-Reply-To: <20201115004151.12899-1-afaerber@suse.de>
On Sun, 15 Nov 2020 01:41:51 +0100
Andreas Färber <afaerber@suse.de> wrote:
> - if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX) {
> + if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX
> + || state->interface == PHY_INTERFACE_MODE_NA) {
> phylink_set(mask, 2500baseT_Full);
> phylink_set(mask, 2500baseX_Full);
> }
No, this will cause, on systems without comphy described, phylink to
think that 2500baseX/T is possible. But without comphy how can it be
configured?
Marek
prev parent reply other threads:[~2020-11-15 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 0:41 [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy Andreas Färber
2020-11-15 1:02 ` Russell King - ARM Linux admin
2020-11-15 2:26 ` Andreas Färber
2020-11-15 8:56 ` Marek Behún
2020-11-15 10:04 ` Russell King - ARM Linux admin
2020-11-15 8:48 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115094827.74eacbc3@kernel.org \
--to=kabel@kernel.org \
--cc=Michal.Hrusecky@nic.cz \
--cc=afaerber@suse.de \
--cc=andrew@lunn.ch \
--cc=bedrich.kosata@nic.cz \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomas.hlavacek@nic.cz \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).