From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F204C63697 for ; Sun, 15 Nov 2020 15:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 548FC2244C for ; Sun, 15 Nov 2020 15:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727256AbgKOP6C (ORCPT ); Sun, 15 Nov 2020 10:58:02 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:56188 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727203AbgKOP6C (ORCPT ); Sun, 15 Nov 2020 10:58:02 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1keKPZ-007CHj-Gm; Sun, 15 Nov 2020 16:57:53 +0100 Date: Sun, 15 Nov 2020 16:57:53 +0100 From: Andrew Lunn To: Martin Blumenstingl Cc: hauke@hauke-m.de, netdev@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: lantiq: Wait for the GPHY firmware to be ready Message-ID: <20201115155753.GC1701029@lunn.ch> References: <20201115100623.257293-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201115100623.257293-1-martin.blumenstingl@googlemail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Add a 300ms delay after initializing all GPHYs to ensure that the GPHY > firmware had enough time to initialize and to appear on the MDIO bus. > Unfortunately there is no (known) documentation on what the minimum time > to wait after releasing the reset on an internal PHY so play safe and > take the one for the external variant. Only wait after the last GPHY > firmware is loaded to not slow down the initialization too much ( > xRX200 has two GPHYs but newer SoCs have at least three GPHYs). Hi Martin Could this be moved into gswip_gphy_fw_list() where the actual firmware download happens? To me that seems like the more logical place. Otherwise Reviewed-by: Andrew Lunn Andrew